Skip to content

refactor: Remove redundant WithImage() calls in Testcontainers setup #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerrettDavis merged 2 commits into from
Feb 16, 2026
Merged

refactor: Remove redundant WithImage() calls in Testcontainers setup #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d09f6
Initial plan
Copilot Feb 16, 2026
fe0d175
refactor: remove redundant WithImage() calls and outdated.txt
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ samples/**/DatabaseProject/**/*.sql
!samples/**/DatabaseProject/**/*.sqlproj
!samples/**/DatabaseProject/**/*.csproj
packages/

# CI-generated dependency reports
outdated.txt
183 changes: 0 additions & 183 deletions outdated.txt
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions src/JD.Efcpt.Build.Tasks/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@
"SQLitePCLRaw.core": "2.1.10"
}
},
"Microsoft.NETFramework.ReferenceAssemblies": {
"type": "Direct",
"requested": "[1.0.3, )",
"resolved": "1.0.3",
"contentHash": "vUc9Npcs14QsyOD01tnv/m8sQUnGTGOw1BCmKcv77LBJY7OxhJ+zJF7UD/sCL3lYNFuqmQEVlkfS4Quif6FyYg==",
"dependencies": {
"Microsoft.NETFramework.ReferenceAssemblies.net472": "1.0.3"
}
},
"MySqlConnector": {
"type": "Direct",
"requested": "[2.5.0, )",
Expand Down Expand Up @@ -493,6 +502,11 @@
"System.Runtime.CompilerServices.Unsafe": "6.1.0"
}
},
"Microsoft.NETFramework.ReferenceAssemblies.net472": {
"type": "Transitive",
"resolved": "1.0.3",
"contentHash": "0E7evZXHXaDYYiLRfpyXvCh+yzM2rNTyuZDI+ZO7UUqSc6GfjePiXTdqJGtgIKUwdI81tzQKmaWprnUiPj9hAw=="
},
"Mono.Unix": {
"type": "Transitive",
"resolved": "7.1.0-final.1.21458.1",
Expand Down
1 change: 0 additions & 1 deletion tests/JD.Efcpt.Build.Tests/Integration/MySqlSchemaIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
private static async Task<TestContext> SetupEmptyDatabase()
{
var container = new MySqlBuilder("mysql:8.0")
.WithImage("mysql:8.0")
.Build();

await container.StartAsync();
Expand Down
3 changes: 1 addition & 2 deletions tests/JD.Efcpt.Build.Tests/Integration/OracleSchemaIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1

private static async Task<TestContext> SetupEmptyDatabase()
{
var container = new OracleBuilder("gvenzl/oracle-xe:21-slim-faststart")
.WithImage("gvenzl/oracle-xe:21.3.0-slim-faststart")
var container = new OracleBuilder("gvenzl/oracle-xe:21.3.0-slim-faststart")
.Build();

await container.StartAsync();
Expand Down
3 changes: 1 addition & 2 deletions tests/JD.Efcpt.Build.Tests/Integration/PostgreSqlSchemaIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1

private static async Task<TestContext> SetupEmptyDatabase()
{
var container = new PostgreSqlBuilder("postgres:16")
.WithImage("postgres:16-alpine")
var container = new PostgreSqlBuilder("postgres:16-alpine")
.Build();

await container.StartAsync();
Expand Down