refactor: Remove redundant WithImage() calls in Testcontainers setup#103
Merged
JerrettDavis merged 2 commits intodeps/consolidated-updatefrom Feb 16, 2026
Merged
refactor: Remove redundant WithImage() calls in Testcontainers setup#103JerrettDavis merged 2 commits intodeps/consolidated-updatefrom
JerrettDavis merged 2 commits intodeps/consolidated-updatefrom
Conversation
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Consolidate dependency updates into a single PR
refactor: Remove redundant WithImage() calls in Testcontainers setup
Feb 16, 2026
JerrettDavis
added a commit
that referenced
this pull request
Feb 17, 2026
* deps: Bump Testcontainers.PostgreSql from 4.4.0 to 4.10.0 --- updated-dependencies: - dependency-name: Testcontainers.PostgreSql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * deps: Bump Testcontainers.FirebirdSql from 4.4.0 to 4.10.0 --- updated-dependencies: - dependency-name: Testcontainers.FirebirdSql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * deps: Bump Testcontainers.MySql from 4.4.0 to 4.10.0 --- updated-dependencies: - dependency-name: Testcontainers.MySql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix obsolete Testcontainers API calls after 4.10.0 upgrade (#91) * Initial plan * Plan to fix obsolete Testcontainers API calls Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> * Fix obsolete Testcontainers API calls Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> * deps: Bump Testcontainers.MsSql from 4.4.0 to 4.10.0 --- updated-dependencies: - dependency-name: Testcontainers.MsSql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Testcontainers.MsSql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix Testcontainers.MsSql 4.10.0 breaking changes (#92) * deps: Bump Testcontainers.MsSql from 4.4.0 to 4.10.0 --- updated-dependencies: - dependency-name: Testcontainers.MsSql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Testcontainers.MsSql dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Initial plan * Fix Testcontainers obsolete constructors to use new API Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> * Update Testcontainers.MsSql to 4.10.0 in Sdk.IntegrationTests Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> Co-authored-by: JD Davis <mxjerrett@gmail.com> * deps: update NuGet packages to latest versions * deps: Bump Testcontainers.Oracle from 4.4.0 to 4.10.0 --- updated-dependencies: - dependency-name: Testcontainers.Oracle dependency-version: 4.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: address build errors from dependency updates - Add 'partial' keyword to all test classes (required by TinyBDD 0.19.2 source generator) - Restore TinyBDD analyzer disabling target (source generator produces broken code) - Fix obsolete parameterless Testcontainers constructors (MySql, Oracle, PostgreSql) - All 858 unit tests passing * refactor: Remove redundant WithImage() calls in Testcontainers setup (#103) * Initial plan * refactor: remove redundant WithImage() calls and outdated.txt Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from PR #102 identifying redundant image specifications in Testcontainers builder setup.
Changes
postgres:16-alpinedirectly in constructor instead of overridingpostgres:16gvenzl/oracle-xe:21.3.0-slim-faststartdirectly instead of overriding21-slim-faststart.WithImage("mysql:8.0")calloutdated.txt(CI-generateddotnet outdatedoutput) and add to.gitignoreBefore
After
Each container builder now has a single, explicit image specification in the constructor.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.