Skip to content

Comments

refactor: Remove redundant WithImage() calls in Testcontainers setup#103

Merged
JerrettDavis merged 2 commits intodeps/consolidated-updatefrom
copilot/sub-pr-102
Feb 16, 2026
Merged

refactor: Remove redundant WithImage() calls in Testcontainers setup#103
JerrettDavis merged 2 commits intodeps/consolidated-updatefrom
copilot/sub-pr-102

Conversation

Copy link
Contributor

Copilot AI commented Feb 16, 2026

Addresses code review feedback from PR #102 identifying redundant image specifications in Testcontainers builder setup.

Changes

  • PostgreSqlBuilder: Use postgres:16-alpine directly in constructor instead of overriding postgres:16
  • OracleBuilder: Use gvenzl/oracle-xe:21.3.0-slim-faststart directly instead of overriding 21-slim-faststart
  • MySqlBuilder: Remove duplicate .WithImage("mysql:8.0") call
  • Remove outdated.txt (CI-generated dotnet outdated output) and add to .gitignore

Before

var container = new PostgreSqlBuilder("postgres:16")
    .WithImage("postgres:16-alpine")
    .Build();

After

var container = new PostgreSqlBuilder("postgres:16-alpine")
    .Build();

Each container builder now has a single, explicit image specification in the constructor.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 16, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.example.com
    • Triggering command: /opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) 386bfa5b8ba7f0d2175a1bc6b5d3081abed3effbd675b67863a27658c5180b40 9 (dns block)
    • Triggering command: /opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) (dns block)
    • Triggering command: /opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) 30249636079ce444548eb83bd11c73ac--root e658d91cc546132f55eac8e77042cf4c/var/run/docker/runtime-runc/moby conf�� ntime.v2.task/moby/1a3437dd6993a/run/containerd/io.containerd.runtime.v2.task/moby/955514d6e25e7xe_w000_XE --local 62d13fb956eca5b8ab9a7ae02369b147ba0/log.json 2e4d6cbe8c8a119c/usr/sbin/iptables 0d2175a1bc6b5d30--wait (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Consolidate dependency updates into a single PR refactor: Remove redundant WithImage() calls in Testcontainers setup Feb 16, 2026
Copilot AI requested a review from JerrettDavis February 16, 2026 23:32
@JerrettDavis JerrettDavis marked this pull request as ready for review February 16, 2026 23:34
@JerrettDavis JerrettDavis merged commit bd6b89d into deps/consolidated-update Feb 16, 2026
2 checks passed
JerrettDavis added a commit that referenced this pull request Feb 17, 2026
* deps: Bump Testcontainers.PostgreSql from 4.4.0 to 4.10.0

---
updated-dependencies:
- dependency-name: Testcontainers.PostgreSql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* deps: Bump Testcontainers.FirebirdSql from 4.4.0 to 4.10.0

---
updated-dependencies:
- dependency-name: Testcontainers.FirebirdSql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* deps: Bump Testcontainers.MySql from 4.4.0 to 4.10.0

---
updated-dependencies:
- dependency-name: Testcontainers.MySql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix obsolete Testcontainers API calls after 4.10.0 upgrade (#91)

* Initial plan

* Plan to fix obsolete Testcontainers API calls

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

* Fix obsolete Testcontainers API calls

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

* deps: Bump Testcontainers.MsSql from 4.4.0 to 4.10.0

---
updated-dependencies:
- dependency-name: Testcontainers.MsSql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: Testcontainers.MsSql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix Testcontainers.MsSql 4.10.0 breaking changes (#92)

* deps: Bump Testcontainers.MsSql from 4.4.0 to 4.10.0

---
updated-dependencies:
- dependency-name: Testcontainers.MsSql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: Testcontainers.MsSql
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Initial plan

* Fix Testcontainers obsolete constructors to use new API

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

* Update Testcontainers.MsSql to 4.10.0 in Sdk.IntegrationTests

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Co-authored-by: JD Davis <mxjerrett@gmail.com>

* deps: update NuGet packages to latest versions

* deps: Bump Testcontainers.Oracle from 4.4.0 to 4.10.0

---
updated-dependencies:
- dependency-name: Testcontainers.Oracle
  dependency-version: 4.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: address build errors from dependency updates

- Add 'partial' keyword to all test classes (required by TinyBDD 0.19.2 source generator)
- Restore TinyBDD analyzer disabling target (source generator produces broken code)
- Fix obsolete parameterless Testcontainers constructors (MySql, Oracle, PostgreSql)
- All 858 unit tests passing

* refactor: Remove redundant WithImage() calls in Testcontainers setup (#103)

* Initial plan

* refactor: remove redundant WithImage() calls and outdated.txt

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants