Skip to content

Refactor: improve exception handling and remove dead code #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Khushi281300 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −9
Open

Refactor: improve exception handling and remove dead code #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions backend/staticfiles/synthesis/lib/inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def create_readonly_wire(name):
def create_number_wire(name, size):
try:
shm = shared_memory.SharedMemory(name=name)
except:
except FileNotFoundError:
shm = shared_memory.SharedMemory(name=name, create=True, size=size)
# self.shms.append(shm)
return shm
Expand All @@ -28,11 +28,6 @@ def __init__(self, input_data) -> None:
self.inputs = input_data
self._enable_data = self.inputs[Inputs.ENABLE_NAME] if Inputs.ENABLE_NAME in self.inputs else None

def _init_enabled(self) -> None:
# This function is redundant for now, its not being used anywhere
self._enable_data = self.inputs[Inputs.ENABLE_NAME] if Inputs.ENABLE_NAME in self.inputs else None
self._enable_condition = Condition(self.inputs[Inputs.ENABLE_NAME]["lock"]) if self.enable_wire else None

def read(self, name):
if self.inputs.get(name) is None:
raise InvalidInputNameException(f"{name} is not declared in inputs")
Expand Down Expand Up @@ -196,9 +191,8 @@ def enabled(self, _enabled: bool):


else:
# Wire doesn't exist yet, ideally has to be created and set
# TODO: Is this case necessary?
# Yep case is definitely necessary especially by this implementation
# Wire doesn't exist yet, so it must be created and set.
# This case is necessary for the current initialization implementation.

if _enabled:
# If the command has been give to enable the wire
Expand Down