Refactor: improve exception handling and remove dead code#446
Open
Khushi281300 wants to merge 1 commit intoJdeRobot:masterfrom
Open
Refactor: improve exception handling and remove dead code#446Khushi281300 wants to merge 1 commit intoJdeRobot:masterfrom
Khushi281300 wants to merge 1 commit intoJdeRobot:masterfrom
Conversation
JdeRobot#443) - Replaced bare \except:\ with \except FileNotFoundError:\ in \create_number_wire()\ to adhere to PEP 8 standards. - Removed the unused \_init_enabled()\ function. - Cleaned up resolved TODO comments regarding wire initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the minor code-quality and technical debt issues I identified in
synthesis/lib/inputs.py.Specifically, it:
except:block toexcept FileNotFoundError:increate_number_wire(), making error handling explicit and aligning with PEP 8 standards._init_enabled(self)function, which was explicitly marked as redundant and unused dead code.Related Issues
Fixes #443