Skip to content

docs(engine): fix stale comment claiming review.linkedIssueSatisfaction is unconsumed #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gittensory-orb merged 1 commit into from
Jul 12, 2026
Merged

docs(engine): fix stale comment claiming review.linkedIssueSatisfaction is unconsumed #5308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/gittensory-engine/src/focus-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,11 @@ export type FocusManifestGateConfig = {
* "unaddressed" verdict become a hard blocker. DB-backed (dashboard-settable too); this overrides the
* stored value -- mirrors `aiReviewMode` above, not the config-as-code-only `unlinkedIssueGuardrail`
* pattern. Distinct from the pre-existing, config-as-code-only `review.linkedIssueSatisfaction` (#2173,
* below) -- that field is parsed but not yet consumed by any decision path; this `gate:` field is the one
* the merge/close decision actually reads. */
* below) in type and storage -- but as of #4149 (`src/signals/focus-manifest.ts`'s
* `resolveEffectiveSettings`, ~line 611-618) `review.linkedIssueSatisfaction` IS folded in as a
* fallback alias whenever this `gate:` field is unset, so setting either spelling drives the same real
* merge/close decision. See `src/types.ts`'s `linkedIssueSatisfactionGateMode` doc for the authoritative
* cross-reference. */
linkedIssueSatisfaction: GateRuleMode | null;
dryRun: boolean | null;
firstTimeContributorGrace: boolean | null;
Expand Down