docs(engine): fix stale comment claiming review.linkedIssueSatisfaction is unconsumed#5308
Conversation
…on is unconsumed True when written (#4069, 2026-07-07), invalidated three days later by #4149 (src/signals/focus-manifest.ts's resolveEffectiveSettings), which added a fallback-alias: when gate.linkedIssueSatisfaction is unset, review.linkedIssueSatisfaction IS folded in and feeds the real merge/close decision. None of the 7 subsequent commits touching this file corrected the comment. src/types.ts already carries the correct, current description. Comment-only, no behavior change. Refs #5284
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 5176767 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 01:38 PM |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-12 13:40:47 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 6 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
`packages/gittensory-engine/src/focus-manifest.ts`'s doc comment on `gate.linkedIssueSatisfaction` said the sibling `review.linkedIssueSatisfaction` field "is parsed but not yet consumed by any decision path." True when written (#4069, 2026-07-07), invalidated three days later by #4149, which added a fallback-alias: when `gate.linkedIssueSatisfaction` is unset, `review.linkedIssueSatisfaction` IS now folded in and feeds the real gate/merge decision. None of the 7 subsequent commits touching this file corrected the comment. `src/types.ts` already carries the correct, current description.
Scope
Comment-only, one file.
Validation
Closes #5284