Skip to content

docs(engine): fix stale comment claiming review.linkedIssueSatisfaction is unconsumed#5308

Merged
gittensory-orb[bot] merged 1 commit into
mainfrom
docs/linked-issue-satisfaction-alias-comment
Jul 12, 2026
Merged

docs(engine): fix stale comment claiming review.linkedIssueSatisfaction is unconsumed#5308
gittensory-orb[bot] merged 1 commit into
mainfrom
docs/linked-issue-satisfaction-alias-comment

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

`packages/gittensory-engine/src/focus-manifest.ts`'s doc comment on `gate.linkedIssueSatisfaction` said the sibling `review.linkedIssueSatisfaction` field "is parsed but not yet consumed by any decision path." True when written (#4069, 2026-07-07), invalidated three days later by #4149, which added a fallback-alias: when `gate.linkedIssueSatisfaction` is unset, `review.linkedIssueSatisfaction` IS now folded in and feeds the real gate/merge decision. None of the 7 subsequent commits touching this file corrected the comment. `src/types.ts` already carries the correct, current description.

Scope

Comment-only, one file.

Validation

  • `npm --workspace @jsonbored/gittensory-engine run build` — clean
  • `npm run typecheck` — clean

Closes #5284

…on is unconsumed

True when written (#4069, 2026-07-07), invalidated three days later
by #4149 (src/signals/focus-manifest.ts's resolveEffectiveSettings),
which added a fallback-alias: when gate.linkedIssueSatisfaction is
unset, review.linkedIssueSatisfaction IS folded in and feeds the
real merge/close decision. None of the 7 subsequent commits touching
this file corrected the comment. src/types.ts already carries the
correct, current description.

Comment-only, no behavior change.

Refs #5284
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 5176767 Commit Preview URL

Branch Preview URL
Jul 12 2026, 01:38 PM

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-07-12 13:40:47 UTC

1 file · 1 AI reviewer · no blockers · readiness 100/100 · CI green · unknown

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
Comment-only fix that corrects a stale doc note claiming review.linkedIssueSatisfaction is unconsumed, updating it to reflect the #4149 fallback-alias behavior and pointing to src/types.ts as the authoritative cross-reference. This is a zero-risk documentation change with no code path affected, and the description's claim about the #4149 fallback aligns with what's shown in the referenced signals/focus-manifest.ts context (a resolveEffectiveSettings-style folding of legacy fields is a common pattern in this codebase). No tests are needed since no logic changed.

Nits — 6 non-blocking
  • The line numbers cited (~611-618) in the comment for resolveEffectiveSettings will drift as the file changes over time; a function-name-only reference would be more durable.
  • Consider dropping the specific line-number range from the comment since it's the kind of detail likely to go stale again, per the very problem this PR is fixing.
  • nit: `packages/gittensory-engine/src/focus-manifest.ts:137` should avoid citing `~line 611-618` in prose because those line numbers will stale quickly while the function name already gives a stable anchor.
  • In `packages/gittensory-engine/src/focus-manifest.ts:137`, change the parenthetical to reference only `src/signals/focus-manifest.ts`'s `resolveEffectiveSettings` rather than approximate line numbers.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5284
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 44 registered-repo PR(s), 36 merged, 476 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 44 PR(s), 476 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 44 PR(s), 476 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit c3ff768 into main Jul 12, 2026
13 checks passed
@gittensory-orb gittensory-orb Bot deleted the docs/linked-issue-satisfaction-alias-comment branch July 12, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix stale doc comment claiming review.linkedIssueSatisfaction is unconsumed

1 participant