fix(observability): remove dangling Orb metric refs, fix duplicate panel id, make github-prs $scope dynamic#5302
Merged
Conversation
…nel id, make github-prs $scope dynamic Phase C of the observability audit: 4 gittensory.json panels referenced gittensory_orb_events_recorded_total/gittensory_orb_installs_total, both retired along with the per-instance Orb App in #1256 but never cleaned out of the dashboard -- they've rendered a permanent 0 ever since, and the locked-in test asserted the broken names as expected content. Removed the 2 panels with no live equivalent (there's no "recorded" step distinct from "exported" in the current fleet-collector architecture) and stripped the dangling series from the 2 mixed panels that partially still work. Also: renumbered a duplicate panel id (158 used by two different panels), fixed a stale alerts.yml comment claiming status-label/latency-histogram metrics are still "being added" (both are fully live), converted github-prs.json's $scope from a hardcoded 5-value custom list to a query-backed variable built from whatever repos are actually tracked in the local reporting DB, and documented (with an empirical Grafana-API check) why the grafana-github-datasource can't be locked read-only like the other 4 datasources without reintroducing the boot-crash risk its API-based provisioning was built to avoid.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5302 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 474 474
Lines 40128 40128
Branches 14631 14631
=======================================
Hits 37869 37869
Misses 1583 1583
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Jul 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase C of the observability audit (dashboard/config correctness sweep, follow-up to #5247/#5259/#5267).
gittensory.jsonhad 4 panels referencinggittensory_orb_events_recorded_total/gittensory_orb_installs_total, both retired along with theper-instance Orb App in feat(orb): fleet calibration collector + analytics (retire per-instance App; feed from review_audit) #1256 (
incr("gittensory_orb_events_recorded_total")was literally deletedin that commit) but never cleaned out of the dashboard — they've rendered a permanent 0 ever since.
Removed the 2 panels with no live equivalent in the new fleet-collector architecture (there's no
"recorded" step distinct from "exported" anymore), stripped the dangling series from the 2 mixed
panels that partially still work, and fixed the test that had locked in the broken names as expected
content.
gittensory.jsonreused id158for two unrelated panels ("MaintenanceAdmission Deferrals (total)" and "Orb Relay Registration: Streak vs Drain Progress"); renumbered.
prometheus/rules/alerts.yml'sgittensory-httpgroup header claimed thestatus-label + duration-histogram metrics were still "being added"; both are fully live in
src/server.tstoday.github-prs.json's$scope— was a hardcoded 5-value custom list (org:JSONbored+ 4 namedrepos). Converted to a query-backed variable built from whatever repos are actually tracked in the
local reporting DB, same pattern as the other dashboards'
$repo/$providervariables.grafana-github-datasourceread-only gap — documented (with an empirical Grafana API check: aPUT with
"readOnly": truein the payload is silently ignored) why this one datasource can't belocked read-only like the other 4 without moving it to file-provisioning, which would reintroduce
the exact boot-crash risk its API-based setup was built to avoid.
has this wired (a
docker-compose.override.yml+alertmanager.localpointing the Discord receiverat a real webhook, predating this session). Confirmed via the Alertmanager API that a real production
alert has been routing to
discordfor hours with zero errors, and a manual test alert routedidentically.
gpu-metrics.jsonfor the same bug classes (dangling refs, hardcoded values) — clean,no findings.
Test plan
npm run typecheck— cleannode scripts/validate-observability-configs.mjs— dashboards/alerts validnpm run test:ci— full local gate green$scopedynamic-variable shape + a real sqlite3-CLI empirical narrowing test
to
discordwith no delivery errors logged)