Skip to content

feat(observability): add a metrics-pipeline smoke test#5342

Merged
JSONbored merged 1 commit into
mainfrom
claude/observability-metrics-smoke-test
Jul 12, 2026
Merged

feat(observability): add a metrics-pipeline smoke test#5342
JSONbored merged 1 commit into
mainfrom
claude/observability-metrics-smoke-test

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Phase C of the observability audit — final item, closing the gap that let two dangling metric
references (fixed in #5302) go undetected for weeks: nothing validated that a dashboard's metric
references actually exist and flow through the pipeline.

scripts/smoke-observability-metrics.mjs mirrors the existing smoke-observability-traces.mjs's
shape: push a synthetic OTLP metric through the collector, confirm it surfaces on its Prometheus
exporter (:8889), and separately sanity-check the app's own /metrics HELP/TYPE shape (an
independent check — the collector path couldn't mask a break in the app's own in-process registry).
Wired as npm run test:smoke:observability:metrics, documented in the self-hosting troubleshooting
doc's new "Grafana metrics/dashboards show no data" section (sibling to the existing traces section).

Test plan

  • npm run typecheck — clean
  • npm run test:ci — full local gate green
  • New test in selfhost-observability-config.test.ts covering the script's content and the
    package.json script wiring, mirroring the existing trace-smoke-script test

Phase C of the observability audit (final item): closes the "nothing
validates a dashboard's metric references actually exist" gap that let
gittensory_orb_events_recorded_total/gittensory_orb_installs_total go
undetected for weeks after their source was deleted.

scripts/smoke-observability-metrics.mjs mirrors the existing trace smoke
script's shape: push a synthetic OTLP metric through the collector, confirm
it surfaces on its Prometheus exporter (:8889), and separately sanity-check
the app's own /metrics HELP/TYPE shape. Wired as
npm run test:smoke:observability:metrics, documented in the self-hosting
troubleshooting doc's new "Grafana metrics/dashboards show no data" section.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 0f48732 Commit Preview URL

Branch Preview URL
Jul 12 2026, 02:08 PM

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.40%. Comparing base (cf58317) to head (0f48732).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5342   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files         550      550           
  Lines       44116    44116           
  Branches    14631    14631           
=======================================
  Hits        41649    41649           
  Misses       1792     1792           
  Partials      675      675           
Flag Coverage Δ
shard-1 44.01% <ø> (ø)
shard-2 34.64% <ø> (ø)
shard-3 31.54% <ø> (ø)
shard-4 31.42% <ø> (ø)
shard-5 33.15% <ø> (ø)
shard-6 43.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@gittensory-orb

Copy link
Copy Markdown

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 Gittensory is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@JSONbored JSONbored self-assigned this Jul 12, 2026
@JSONbored JSONbored merged commit 06cdb80 into main Jul 12, 2026
21 checks passed
@JSONbored JSONbored deleted the claude/observability-metrics-smoke-test branch July 12, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant