feat(observability): add a metrics-pipeline smoke test#5342
Merged
Conversation
Phase C of the observability audit (final item): closes the "nothing validates a dashboard's metric references actually exist" gap that let gittensory_orb_events_recorded_total/gittensory_orb_installs_total go undetected for weeks after their source was deleted. scripts/smoke-observability-metrics.mjs mirrors the existing trace smoke script's shape: push a synthetic OTLP metric through the collector, confirm it surfaces on its Prometheus exporter (:8889), and separately sanity-check the app's own /metrics HELP/TYPE shape. Wired as npm run test:smoke:observability:metrics, documented in the self-hosting troubleshooting doc's new "Grafana metrics/dashboards show no data" section.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 0f48732 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 02:08 PM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5342 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 550 550
Lines 44116 44116
Branches 14631 14631
=======================================
Hits 41649 41649
Misses 1792 1792
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase C of the observability audit — final item, closing the gap that let two dangling metric
references (fixed in #5302) go undetected for weeks: nothing validated that a dashboard's metric
references actually exist and flow through the pipeline.
scripts/smoke-observability-metrics.mjsmirrors the existingsmoke-observability-traces.mjs'sshape: push a synthetic OTLP metric through the collector, confirm it surfaces on its Prometheus
exporter (
:8889), and separately sanity-check the app's own/metricsHELP/TYPE shape (anindependent check — the collector path couldn't mask a break in the app's own in-process registry).
Wired as
npm run test:smoke:observability:metrics, documented in the self-hosting troubleshootingdoc's new "Grafana metrics/dashboards show no data" section (sibling to the existing traces section).
Test plan
npm run typecheck— cleannpm run test:ci— full local gate greenselfhost-observability-config.test.tscovering the script's content and thepackage.jsonscript wiring, mirroring the existing trace-smoke-script test