CompatForm: Insert duplicate submit button when more than one is present#104
CompatForm: Insert duplicate submit button when more than one is present#104
Conversation
e51b859 to
8e44197
Compare
|
What about overriding I'd like to just use the trait and be done with it. Calling a special method, in this case, is too tedious for me 😉 |
if I would use the Trait in |
|
I see. I forgot that this is only relevant if there are multiple submit buttons and then the set submit button isn't reliable. (even if available) |
50044d5 to
bb88818
Compare
c5a5b4f to
e540ffb
Compare
nilmerg
left a comment
There was a problem hiding this comment.
Please also add a another test case to CompatFormTest which verifies that an explicit call to setSubmitButton() duplicates said submit button, and not the first registered one.
nilmerg
left a comment
There was a problem hiding this comment.
Please squash your commits to the following:
- One for the trait + less file
- One for the composer.json
- One for the CompatFormTest
- One for the DuplicateSubmitButttonTest + TestCase
c73fa30 to
7cfc922
Compare
7cfc922 to
7dc5d98
Compare
969655b to
43a6800
Compare
lippserd
left a comment
There was a problem hiding this comment.
PR title and description have to be adjusted as well.
PrefixSubmitButton Trait0ad95ab to
857b6bf
Compare
e6393f3 to
7b624ba
Compare
7b624ba to
c508a5d
Compare
c508a5d to
811318c
Compare
Creates a new
SubmitElementfrom the primary submit button of the form with cloned Attributes from the givenFormSubmitElement. The new submit button is always at the top of the form.The element has a fixed
primary-submit-btn-duplicateclass, which hides to button, but not the functionality when submitting the form.