Skip to content

Compatibility with breaking ipl-sdtlib changes #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BastianLedererIcinga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compatibility with breaking ipl-sdtlib changes #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
"require": {
"php": ">=8.2",
"ext-fileinfo": "*",
"ipl/stdlib": ">=0.12.0",
"ipl/stdlib": "dev-modernize-code-with-breaking-changes",
"ipl/validator": ">=0.5.0",
"psr/http-message": "^1.1",
"guzzlehttp/psr7": "^2.8"
},
"require-dev": {
"ext-dom": "*",
"ipl/stdlib": "dev-main",
"ipl/stdlib": "dev-modernize-code-with-breaking-changes",
"ipl/validator": "dev-main"
},
"autoload": {
Expand Down
2 changes: 1 addition & 1 deletion src/FormElement/FormElements.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ protected function decorate(FormElement $element)
return $this;
}

public function isValidEvent($event)
public function isValidEvent(string $event): bool
Copy link
Copy Markdown
Member

@lippserd lippserd Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also a forward-compatible change, right? If so, remove the composer.json bump and update the PR title and description accordingly.

Copy link
Copy Markdown
Member

@lippserd lippserd Mar 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked that string is added. PR is fine, sorry!

{
return in_array($event, [
Form::ON_SUBMIT,
Expand Down
Loading