Compatibility with breaking ipl-sdtlib changes#189
Open
BastianLedererIcinga wants to merge 1 commit intomainfrom
Open
Compatibility with breaking ipl-sdtlib changes#189BastianLedererIcinga wants to merge 1 commit intomainfrom
BastianLedererIcinga wants to merge 1 commit intomainfrom
Conversation
BastianLedererIcinga
force-pushed
the
breaking-modernize-dependencies
branch
from
efbabbc to
d02eb4e
Compare
Add strict types for compatibility with ipl-stdlib
BastianLedererIcinga
force-pushed
the
breaking-modernize-dependencies
branch
from
d02eb4e to
6e4db92
Compare
lippserd
reviewed
Mar 23, 2026
Member
lippserd
left a comment
lippserd
left a comment
There was a problem hiding this comment.
That's also a forward-compatible change, right? If so, remove the composer.json bump and update the PR title and description accordingly.
| } | ||
|
|
||
| public function isValidEvent($event) | ||
| public function isValidEvent(string $event): bool |
Member
There was a problem hiding this comment.
That's also a forward-compatible change, right? If so, remove the composer.json bump and update the PR title and description accordingly.
Member
There was a problem hiding this comment.
I overlooked that string is added. PR is fine, sorry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add strict types to
FormElements::isValidEvent().requires Icinga/ipl-stdlib#69