chore: fix lint errors - remove unused catch parameter, apply prettier

.github/workflows/CI.yml

@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 16.9
+          node-version: 20
       - run: npm i
       - run: npm run lint
       - run: npm test
@@ -27,9 +27,9 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 16.9
+          node-version: 20
       - run: npm i
-      - run: npm run coverage
+      - run: npm run test:coverage
       - uses: codecov/codecov-action@v1
 
   publish-npm:
@@ -42,7 +42,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 16.9
+          node-version: 20
           registry-url: https://registry.npmjs.org/
           scope: '@hydre'
       - run: npm ci

package.json

@@ -10,7 +10,7 @@
     "./tinyhttp": "./src/tinyhttp.js"
   },
   "scripts": {
-    "test": "node --test test/**/*.test.js",
+    "test": "node --test test/*.test.js",
     "test:coverage": "c8 --reporter=text --reporter=html --reporter=lcov npm test",
     "typecheck": "tsc --noEmit",
     "lint": "eslint . && prettier . --check",

src/fastify.js

@@ -9,8 +9,16 @@ const Fastify = ({ body }, reply) => {
   } catch (error) {
     const graphql_error =
       error instanceof GraphQLError ? error : new GraphQLError(error.message)
-    reply.status(200).type('application/json').send({ errors: [graphql_error] })
-    return { query: null, variable_values: null, operation_name: null, reply: () => {} }
+    reply
+      .status(200)
+      .type('application/json')
+      .send({ errors: [graphql_error] })
+    return {
+      query: null,
+      variable_values: null,
+      operation_name: null,
+      reply: () => {},
+    }
   }
 
   const { query, variables, operationName, operation_name } = body

src/koa.js

@@ -14,7 +14,12 @@ const Koa = context => {
     context.status = 200
     context.type = 'application/json'
     context.body = { errors: [graphql_error] }
-    return { query: null, variable_values: null, operation_name: null, reply: () => {} }
+    return {
+      query: null,
+      variable_values: null,
+      operation_name: null,
+      reply: () => {},
+    }
   }
 
   const { query, variables, operationName, operation_name } = request_body

src/lambda.js

@@ -7,7 +7,7 @@ const Lambda = ({ body: raw_body }, context, reply) => {
   let parsed
   try {
     parsed = JSON.parse(raw_body)
-  } catch (error) {
+  } catch {
     reply(null, {
       statusCode: 400,
       body: JSON.stringify({
@@ -24,7 +24,9 @@ const Lambda = ({ body: raw_body }, context, reply) => {
     reply(null, {
       statusCode: 200,
       body: JSON.stringify({
-        errors: [error instanceof GraphQLError ? error : { message: error.message }],
+        errors: [
+          error instanceof GraphQLError ? error : { message: error.message },
+        ],
       }),
     })
     return { query: null, variable_values: null, operation_name: null, reply }

src/tinyhttp.js

@@ -10,7 +10,12 @@ const TinyHttp = ({ body = {} }, response) => {
     const graphql_error =
       error instanceof GraphQLError ? error : new GraphQLError(error.message)
     response.status(200).json({ errors: [graphql_error] })
-    return { query: null, variable_values: null, operation_name: null, reply: () => {} }
+    return {
+      query: null,
+      variable_values: null,
+      operation_name: null,
+      reply: () => {},
+    }
   }
 
   const { query, variables, operationName, operation_name } = body

test/fastify.test.js

@@ -10,12 +10,12 @@ import graphql_http from '../src/fastify.js'
 async function create_server(options) {
   const fastify = Fastify()
   fastify.post('/', graphql_http(options))
-  await fastify.listen({ port: 3001 })
+  await fastify.listen({ port: 3002 })
   return fastify
 }
 
 async function request({ query, variables = {}, operation_name = null } = {}) {
-  const response = await fetch('http://localhost:3001', {
+  const response = await fetch('http://localhost:3002', {
     method: 'POST',
     headers: {
       'Content-Type': 'application/json',

test/index.test.js

@@ -145,12 +145,15 @@ test('koa adapter', async t => {
     }
   })
 
-  await t.test('should return error for query exceeding size limit', async () => {
-    const huge_query = `{ ${'me { name } '.repeat(20000)} }`
-    const { errors } = await request({ query: huge_query })
-    assert.ok(errors)
-    assert.ok(errors[0].message.toLowerCase().includes('too large'))
-  })
+  await t.test(
+    'should return error for query exceeding size limit',
+    async () => {
+      const huge_query = `{ ${'me { name } '.repeat(20000)} }`
+      const { errors } = await request({ query: huge_query })
+      assert.ok(errors)
+      assert.ok(errors[0].message.toLowerCase().includes('too large'))
+    },
+  )
 
   await t.test('should timeout slow build_context', async () => {
     const Koa = (await import('koa')).default

test/lambda.test.js

@@ -146,18 +146,21 @@ test('lambda adapter', async t => {
     assert.ok(body.errors[0].message.toLowerCase().includes('json'))
   })
 
-  await t.test('should return error for query exceeding size limit', async () => {
-    const huge_query = `{ ${'me { name } '.repeat(20000)} }`
-    const event = create_lambda_event({
-      query: huge_query,
-    })
-    const result = await invoke_lambda(event)
-
-    assert.strictEqual(result.statusCode, 200)
-    const body = JSON.parse(result.body)
-    assert.ok(body.errors)
-    assert.ok(body.errors[0].message.toLowerCase().includes('too large'))
-  })
+  await t.test(
+    'should return error for query exceeding size limit',
+    async () => {
+      const huge_query = `{ ${'me { name } '.repeat(20000)} }`
+      const event = create_lambda_event({
+        query: huge_query,
+      })
+      const result = await invoke_lambda(event)
+
+      assert.strictEqual(result.statusCode, 200)
+      const body = JSON.parse(result.body)
+      assert.ok(body.errors)
+      assert.ok(body.errors[0].message.toLowerCase().includes('too large'))
+    },
+  )
 
   await t.test('should return error for non-object request body', async () => {
     const event = {