Skip to content

chore: fix lint errors - remove unused catch parameter, apply prettier #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sceat merged 6 commits into from
Nov 6, 2025
Merged

chore: fix lint errors - remove unused catch parameter, apply prettier #26

Sceat merged 6 commits into from
Nov 6, 2025

Conversation

@Sceat
Copy link
Member

@Sceat Sceat commented Nov 6, 2025

Summary

Small cleanup commit to fix linting issues that appeared after the security hardening PR.

Changes

  • Lambda adapter: Removed unused error parameter in JSON.parse catch block (ES2019+ allows omitting catch parameters)
  • Prettier formatting: Applied consistent formatting across all modified files

Verification

✓ npm run lint passes
✓ 33/33 tests passing
✓ Coverage maintained: 86.68% stmts, 80% branch, 73.68% funcs

🤖 Generated with Claude Code

@Sceat Sceat requested a review from DeltaEvo as a code owner November 6, 2025 19:13
Sceat added 5 commits November 7, 2025 02:21
@Sceat
fix(ci): update Node.js version to 20 for ESLint 9 compatibility
f71bd5d 
ESLint 9 requires Node.js 18.18+ or 20.9+ (uses structuredClone).
Updated all CI jobs from Node 16.9 to Node 20.
@Sceat
fix(test): quote glob pattern for cross-platform compatibility
4bf4347 
Node's --test flag requires quoted glob patterns in npm scripts
to work correctly across different shells (bash/sh/zsh).
@Sceat
fix(test): use simple glob pattern instead of recursive
d2676ca 
Changed from test/**/*.test.js to test/*.test.js since all test
files are in the root test directory. The recursive glob wasn't
expanding correctly in CI bash environment.
@Sceat
fix(test): change fastify test port to 3002 to avoid conflicts
34f1bee 
Fastify tests were conflicting with Koa timeout test (both using port 3001).
Changed fastify to use port 3002 to prevent EADDRINUSE errors in parallel test execution.
@Sceat
fix(ci): use correct coverage script name
4698747 
Changed from 'npm run coverage' to 'npm run test:coverage'
to match the actual script name in package.json.
@Sceat Sceat merged commit b07f7c7 into edge Nov 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeltaEvo DeltaEvo Awaiting requested review from DeltaEvo DeltaEvo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sceat