-
Notifications
You must be signed in to change notification settings - Fork 19
Jawad A. #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jivvyjams
wants to merge
5
commits into
HackYourAssignment:main
Choose a base branch
from
jivvyjams:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jawad A. #17
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| function isBookApplicable(searchString) { | ||
| // Your code here | ||
| import PromptSync from "prompt-sync"; | ||
| const prompt = PromptSync(); | ||
|
|
||
| const queryUser = prompt(`Please enter your search query: `); | ||
| const searchString = queryUser.toLowerCase().trim(); | ||
| const bookTitle = `The fundamentals of JavaScript`.toLowerCase(); | ||
|
|
||
| function isBookApplicable() { | ||
| if (searchString === bookTitle || bookTitle.includes(searchString)) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| console.log(isBookApplicable()); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,18 @@ | ||
| // Your code here | ||
| function parseDateString(dateString) { | ||
| let parts = dateString.split(" "); | ||
| let format = parts[0]; | ||
| let date = parts[1]; | ||
| let splitDate = date.split("-"); | ||
|
|
||
| let firstDate = Number(splitDate[0]); | ||
| let secondDate = Number(splitDate[1]); | ||
| let thirdDate = Number(splitDate[2]); | ||
|
|
||
| if (format === "MDY") { | ||
| return {day: secondDate, month: firstDate, year: thirdDate} | ||
| } else if (format === "DMY") { | ||
| return {day: secondDate, month: firstDate, year: thirdDate} | ||
| } else { | ||
| return `Error! Please enter a valid date format.`; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| export function convertHoursToMinutes(hours) { | ||
| return hours * 60; | ||
| } | ||
|
|
||
| export function convertMinutesToHours(minutes) { | ||
| return minutes / 60; | ||
| } | ||
|
|
||
| export function convertDaysToHours(days) { | ||
| return days * 24; | ||
| } | ||
|
|
||
| export function convertHoursToDays(hours) { | ||
| return hours / 24; | ||
| } | ||
|
|
||
| export function convertMinutesToSeconds(minutes) { | ||
| return minutes * 60; | ||
| } | ||
|
|
||
| export function convertSecondsToMinutes(seconds) { | ||
| return seconds / 60; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,80 +1,49 @@ | ||
| // Temperature conversion and weather report for City 1 | ||
| let cityName1 = "Amsterdam"; | ||
| let tempCelsius1 = 22; | ||
| let tempFahrenheit1 = (tempCelsius1 * 9 / 5) + 32; | ||
| let tempKelvin1 = tempCelsius1 + 273.15; | ||
| console.log("Weather Report for " + cityName1); | ||
| console.log("Temperature: " + tempCelsius1 + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit1 + "°F"); | ||
| console.log("Temperature: " + tempKelvin1 + "K"); | ||
| if (tempCelsius1 < 0) { | ||
| console.log("Status: Freezing"); | ||
| } else if (tempCelsius1 >= 0 && tempCelsius1 < 10) { | ||
| console.log("Status: Cold"); | ||
| } else if (tempCelsius1 >= 10 && tempCelsius1 < 20) { | ||
| console.log("Status: Mild"); | ||
| } else if (tempCelsius1 >= 20 && tempCelsius1 < 30) { | ||
| console.log("Status: Warm"); | ||
| } else { | ||
| console.log("Status: Hot"); | ||
| /* I could not figure out how to properly create arrays | ||
| and call the function using them as input for the printWeather function | ||
| */ | ||
|
|
||
| const cities = [ | ||
| { city: "Amsterdam", temp: 22, windSpeed: 15 }, | ||
| { city: "Berlin", temp: 15, windSpeed: 20 }, | ||
| { city: "Copenhagen",temp: -5, windSpeed: 25 } | ||
| ]; | ||
|
|
||
| function convertToFahrenheit(temp) { | ||
| return temp * 9 / 5 + 32; | ||
| } | ||
| console.log("---"); | ||
|
|
||
| // Temperature conversion and weather report for City 2 | ||
| let cityName2 = "Berlin"; | ||
| let tempCelsius2 = 15; | ||
| let tempFahrenheit2 = (tempCelsius2 * 9 / 5) + 32; | ||
| let tempKelvin2 = tempCelsius2 + 273.15; | ||
| console.log("Weather Report for " + cityName2); | ||
| console.log("Temperature: " + tempCelsius2 + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit2 + "°F"); | ||
| console.log("Temperature: " + tempKelvin2 + "K"); | ||
| if (tempCelsius2 < 0) { | ||
| console.log("Status: Freezing"); | ||
| } else if (tempCelsius2 >= 0 && tempCelsius2 < 10) { | ||
| console.log("Status: Cold"); | ||
| } else if (tempCelsius2 >= 10 && tempCelsius2 < 20) { | ||
| console.log("Status: Mild"); | ||
| } else if (tempCelsius2 >= 20 && tempCelsius2 < 30) { | ||
| console.log("Status: Warm"); | ||
| } else { | ||
| console.log("Status: Hot"); | ||
| function convertToKelvin(temp) { | ||
| return temp + 273.15; | ||
| } | ||
| console.log("---"); | ||
|
|
||
| // Temperature conversion and weather report for City 3 | ||
| let cityName3 = "Copenhagen"; | ||
| let tempCelsius3 = -5; | ||
| let tempFahrenheit3 = (tempCelsius3 * 9 / 5) + 32; | ||
| let tempKelvin3 = tempCelsius3 + 273.15; | ||
| console.log("Weather Report for " + cityName3); | ||
| console.log("Temperature: " + tempCelsius3 + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit3 + "°F"); | ||
| console.log("Temperature: " + tempKelvin3 + "K"); | ||
| if (tempCelsius3 < 0) { | ||
| console.log("Status: Freezing"); | ||
| } else if (tempCelsius3 >= 0 && tempCelsius3 < 10) { | ||
| console.log("Status: Cold"); | ||
| } else if (tempCelsius3 >= 10 && tempCelsius3 < 20) { | ||
| console.log("Status: Mild"); | ||
| } else if (tempCelsius3 >= 20 && tempCelsius3 < 30) { | ||
| console.log("Status: Warm"); | ||
| } else { | ||
| console.log("Status: Hot"); | ||
| function calcWindChill(temp, windSpeed) { | ||
| return 13.12 + 0.6215 * temp - 11.37 * Math.pow(windSpeed, 0.16) + 0.3965 * temp * Math.pow(windSpeed, 0.16); | ||
| } | ||
| console.log("---"); | ||
|
|
||
| // Wind chill calculation for City 1 | ||
| let windSpeed1 = 15; | ||
| let windChill1 = 13.12 + 0.6215 * tempCelsius1 - 11.37 * Math.pow(windSpeed1, 0.16) + 0.3965 * tempCelsius1 * Math.pow(windSpeed1, 0.16); | ||
| console.log("Wind chill in " + cityName1 + ": " + windChill1.toFixed(2) + "°C"); | ||
| function tempStatus(temp) { | ||
| if (temp < 0) { | ||
| return `Freezing`; | ||
| } else if (temp < 10) { | ||
| return `Cold`; | ||
| } else if (temp < 20) { | ||
| return `Mild`; | ||
| } else if (temp < 30) { | ||
| return `Warm`; | ||
| } else { | ||
| return `Hot`; | ||
| } | ||
| } | ||
|
|
||
| // Wind chill calculation for City 2 | ||
| let windSpeed2 = 20; | ||
| let windChill2 = 13.12 + 0.6215 * tempCelsius2 - 11.37 * Math.pow(windSpeed2, 0.16) + 0.3965 * tempCelsius2 * Math.pow(windSpeed2, 0.16); | ||
| console.log("Wind chill in " + cityName2 + ": " + windChill2.toFixed(2) + "°C"); | ||
| function printWeather(city, temp, windSpeed) { | ||
| const tempF = convertToFahrenheit(temp).toFixed(2); | ||
| const tempK = convertToKelvin(temp).toFixed(2); | ||
| const status = tempStatus(temp) | ||
| const windChill = calcWindChill(temp, windSpeed).toFixed(2); | ||
|
|
||
| // Wind chill calculation for City 3 | ||
| let windSpeed3 = 25; | ||
| let windChill3 = 13.12 + 0.6215 * tempCelsius3 - 11.37 * Math.pow(windSpeed3, 0.16) + 0.3965 * tempCelsius3 * Math.pow(windSpeed3, 0.16); | ||
| console.log("Wind chill in " + cityName3 + ": " + windChill3.toFixed(2) + "°C"); | ||
| console.log(`Weather Report for ${city}`); | ||
| console.log(`Temperature: ${temp} °C`); | ||
| console.log(`Temperature: ${tempF} °F`); | ||
| console.log(`Temperature: ${tempK} K`); | ||
| console.log(`Status: ${status}`); | ||
| console.log(`Wind chill in ${city}: ${windChill} °C`) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In JS, it is more common to use just 2 spaces of indentation.
But aside that, it is all good :)
Others weren't using the prompt, but it is fine.