Skip to content

Jawad A.#17

Open
jivvyjams wants to merge 5 commits intoHackYourAssignment:mainfrom
jivvyjams:main
Open

Jawad A.#17
jivvyjams wants to merge 5 commits intoHackYourAssignment:mainfrom
jivvyjams:main

Conversation

@jivvyjams
Copy link

No description provided.

@github-actions

This comment has been minimized.

@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

Copy link

@rafaelhdr rafaelhdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exercises 1 to 3 are great. Just a minor suggesion of indentation.

But there is a tiny issue with the last one.

The refactored code should produce the same output as the original

THe task 4 is currently not making any output. Check that, and this will be complete 👍

const bookTitle = `The fundamentals of JavaScript`.toLowerCase();

function isBookApplicable() {
if (searchString === bookTitle || bookTitle.includes(searchString)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JS, it is more common to use just 2 spaces of indentation.

But aside that, it is all good :)

Others weren't using the prompt, but it is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants