Conversation
alexschmander
left a comment
There was a problem hiding this comment.
Initial review. Will continue when #2154 is merged.
17a872e to
706d150
Compare
4ed509f to
7febaa5
Compare
@alexschmander #2154 is merged, you can review this |
7febaa5 to
6fc95bc
Compare
|
@schmidma you could review this again now. I should probably not review it myself, since I worked on the the last couple commits... |
`/booster_camera_bridge/StereoNetNode/rectified_image` -> `booster/rectified_image` `/booster_camera_bridge/image_left_raw` -> `booster/image_left_raw` `/booster_camera_bridge/image_left_raw/camera_info` -> `booster/image_left_raw/camera_info`
- `/booster_camera_bridge/StereoNetNode/rectified_right_image` -> `booster/rectified_right_image` - `/booster_camera_bridge/StereoNetNode/stereonet_depth` -> `booster/stereonet_depth` - `/booster_camera_bridge/StereoNetNode/stereonet_visual` -> `booster/stereonet_visual` - `/booster_camera_bridge/image_right_raw` -> `booster/image_right_raw` - `/booster_camera_bridge/image_right_raw/camera_info` -> `booster/image_left_raw/camera_info`
6fc95bc to
aefe5a4
Compare
knoellle
left a comment
There was a problem hiding this comment.
Looks fine for now.
We're already using this as if it was merged already and doing work on top of it.
Since this doesn't change existing code and only adds something new, I think we should merge it and then iterate on main.
|
I think my review already was very kind. My comments mostly only addressed issues, I think are actual bugs. Are these issues addressed already? Then I'd be happy to have a final look on it |
|
@schmidma I addressed the comments you made. Since @julianschuler does not have the time currently to continue working on this, during the last dev meeting we decided we wanted to forgo stylistic changes in favor of getting this PR finally merged. If the remaining comments are not critical bugs, perhaps we could simply merge this? |
|
@schmidma alex addressed your comments but you haven't said anything since. |
Why? What?
This PR adds a bridge to make the booster ROS interfaces available via zenoh.
Blocked on #2154.
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Then, listen to the available zenoh topics, e.g. using zenoh-cli.