Conversation
schmidma
force-pushed
the
dont-hesitate-to-maybe-overcompensate
branch
from
8561922 to
1e86b6e
Compare
schmidma
force-pushed
the
dont-hesitate-to-maybe-overcompensate
branch
2 times, most recently
from
0f8e9a7 to
b60caf9
Compare
schmidma
force-pushed
the
dont-hesitate-to-maybe-overcompensate
branch
from
6e0a895 to
114d6fe
Compare
|
I gave this another bump, review, cleanup and rebase... |
rmburg
left a comment
rmburg
left a comment
There was a problem hiding this comment.
only a few nitpicks, otherwise very nice changes! Looking forward to this on crates.io :)
schmidma
force-pushed
the
dont-hesitate-to-maybe-overcompensate
branch
from
9827e0c to
353d903
Compare
| /// # Example | ||
| /// ```rust | ||
| /// use linear_algebra::{point, Point2}; | ||
| /// | ||
| /// struct World; | ||
| /// let p: Point2<World> = point![1.0, 2.0]; | ||
| /// ``` |
There was a problem hiding this comment.
Please add another example that specifies the frame within the macro.
let p = point![<World>, 1.0, 2.0];There was a problem hiding this comment.
The whole point (heh) of being able to specify the frame inside the macro was being able to omit more verbose type information elsewhere.
| /// # Example | ||
| /// ```rust | ||
| /// use linear_algebra::{vector, Vector2}; | ||
| /// | ||
| /// struct World; | ||
| /// let v: Vector2<World> = vector![1.0, 2.0]; | ||
| /// ``` |
There was a problem hiding this comment.
Please add another example that specifies the frame within the macro.
let p = vector![<World>, 1.0, 2.0];| //! - Wraps commonly used parts of the [`nalgebra`] API to provide frame-safe abstractions. | ||
| //! - Supports 2D and 3D geometry with extensible coordinate system tagging. | ||
| //! - Provides clear and explicit geometric transformations. | ||
| //! - Re-exports [`nalgebra`] so `point!` and `vector!` work without a direct dependency. |
There was a problem hiding this comment.
Is this a "feature"?
I think its an implementation detail. It would work fine too if instead of wrapping nalgebra's macros we had copied them instead.
There was a problem hiding this comment.
rephrased some of the docstrings
There was a problem hiding this comment.
I'm still not convinced the re-exporting is a feature worthy of being listed here.
| assert!((isometry.angle() - 0.5).abs() < 1.0e-6); | ||
| assert!((isometry.rotation().angle() - 0.5).abs() < 1.0e-6); |
There was a problem hiding this comment.
This seems like a job for approx
4 participants
Why? What?
This PR prepares
linear_algebrato be published, cleaning up structure and some naming, as well as providing feature flags and documentation.fixes #1893