Skip to content

nml/eclm: Added snow_thermal_cond parameters#30

Merged
kvrigor merged 4 commits into
masterfrom
snow-thermal-cond-params
May 27, 2026
Merged

nml/eclm: Added snow_thermal_cond parameters#30
kvrigor merged 4 commits into
masterfrom
snow-thermal-cond-params

Conversation

@kvrigor
Copy link
Copy Markdown
Member

@kvrigor kvrigor commented May 5, 2026

@kvrigor kvrigor marked this pull request as ready for review May 6, 2026 05:04
@kvrigor
Copy link
Copy Markdown
Member Author

kvrigor commented May 6, 2026

@s-poll : the latest nml/eclm also carries this drv_in modification:

- calendar = "NO_LEAP"
+ calendar = "GREGORIAN"

Is this supposed to be a fix or an experimental change? Not sure if this should be merged or not.

@kvrigor
Copy link
Copy Markdown
Member Author

kvrigor commented May 27, 2026

I'm reverting the drv_in change to make this PR only modify these lnd_in values:

 snow_thermal_cond_method = 'Jordan1991'
 snow_thermal_cond_glc_method = 'Jordan1991'
 snow_thermal_cond_lake_method = 'Jordan1991'

@kvrigor kvrigor requested a review from AGonzalezNicolas May 27, 2026 11:12
@kvrigor kvrigor merged commit 6cd9911 into master May 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants