Skip to content

fix(gae): remove duplicate and redundant region tags "dependencies" #10289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kef131 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(gae): remove duplicate and redundant region tags "dependencies" #10289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appengine-java8/endpoints-v2-skeleton/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ apply plugin: 'com.google.cloud.tools.endpoints-framework-server'
apply plugin: 'com.google.cloud.tools.appengine'
// [END plugin_applys]

// [START dependencies]
// [START appengine_endpoints_gradle_dependencies]
dependencies {
compile 'com.google.endpoints:endpoints-framework:2.2.2'
compile 'com.google.appengine:appengine-api-1.0-sdk:2.0.23'

compile 'javax.inject:javax.inject:1'
compileOnly 'javax.servlet:javax.servlet-api:3.1.0'
}
// [END dependencies]
// [END appengine_endpoints_gradle_dependencies]

// [START endpoints_server_configuration]
// You must replace YOUR_PROJECT_ID with your Google Cloud Project Id
Expand Down
2 changes: 0 additions & 2 deletions appengine-java8/mailgun/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
<type>jar</type>
<scope>provided</scope>
</dependency>
<!-- [START dependencies] -->
<dependency>
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-core</artifactId>
Expand All @@ -60,7 +59,6 @@
<artifactId>jersey-multipart</artifactId>
<version>1.19.4</version>
</dependency>
<!-- [END dependencies] -->
</dependencies>
<build>
<!-- for hot reload of the web application -->
Expand Down
2 changes: 0 additions & 2 deletions appengine-java8/mailjet/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
<scope>provided</scope>
</dependency>

<!-- [START dependencies] -->
<dependency>
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-core</artifactId>
Expand All @@ -66,7 +65,6 @@
<artifactId>jersey-multipart</artifactId>
<version>1.19.4</version>
</dependency>
<!-- [END dependencies] -->
</dependencies>
<build>
<!-- for hot reload of the web application -->
Expand Down
2 changes: 0 additions & 2 deletions appengine-java8/memcache/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ Copyright 2015 Google Inc.
<scope>provided</scope>
</dependency>

<!-- [START dependencies] -->
<dependency>
<groupId>com.google.appengine</groupId>
<artifactId>appengine-api-1.0-sdk</artifactId>
Expand All @@ -56,7 +55,6 @@ Copyright 2015 Google Inc.
<artifactId>xmemcached</artifactId>
<version>2.4.8</version>
</dependency>
<!-- [END dependencies] -->
</dependencies>
<build>
<!-- for hot reload of the web application -->
Expand Down
4 changes: 0 additions & 4 deletions appengine-java8/pubsub/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
<failOnMissingWebXml>false</failOnMissingWebXml> <!-- REQUIRED -->
</properties>

<!-- [START dependencies] -->
<!-- Using libraries-bom to manage versions.
See https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM -->
<dependencyManagement>
Expand All @@ -62,7 +61,6 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore</artifactId>
</dependency>
<!-- [END dependencies] -->
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
Expand All @@ -75,9 +73,7 @@
<artifactId>jatl</artifactId>
<version>0.2.3</version>
</dependency>
<!-- [START dependencies] -->
</dependencies>
<!-- [END dependencies] -->
<build>
<!-- for hot reload of the web application -->
<outputDirectory>${project.build.directory}/${project.build.finalName}/WEB-INF/classes</outputDirectory>
Expand Down
2 changes: 0 additions & 2 deletions appengine-java8/remote-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
</properties>

<dependencies>
<!-- [START dependencies] -->
<dependency>
<groupId>com.google.appengine</groupId>
<artifactId>appengine-remote-api</artifactId>
Expand All @@ -47,7 +46,6 @@
<artifactId>appengine-api-1.0-sdk</artifactId>
<version>2.0.23</version>
</dependency>
<!-- [END dependencies] -->
</dependencies>
<build>
<!-- for hot reload of the web application -->
Expand Down
4 changes: 0 additions & 4 deletions appengine-java8/translate-pubsub/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
<maven.compiler.source>1.8</maven.compiler.source>
</properties>

<!-- [START dependencies] -->
<!-- Using libraries-bom to manage versions.
See https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM -->
<dependencyManagement>
Expand Down Expand Up @@ -65,17 +64,14 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-translate</artifactId>
</dependency>
<!-- [END dependencies] -->
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<version>3.1.0</version>
<type>jar</type>
<scope>provided</scope>
</dependency>
<!-- [START dependencies] -->
</dependencies>
<!-- [END dependencies] -->
<build>
<!-- for hot reload of the web application -->
<outputDirectory>${project.build.directory}/${project.build.finalName}/WEB-INF/classes</outputDirectory>
Expand Down