fix(gae): remove duplicate and redundant region tags "dependencies"#10289
Draft
Kef131 wants to merge 1 commit into
Draft
fix(gae): remove duplicate and redundant region tags "dependencies"#10289Kef131 wants to merge 1 commit into
Kef131 wants to merge 1 commit into
Conversation
…radle dependency tag name
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates region tags across several App Engine Java 8 sample projects. Specifically, in the build.gradle file for endpoints-v2-skeleton, the generic dependencies region tags are renamed to appengine_endpoints_gradle_dependencies. In several other pom.xml files (including mailgun, mailjet, memcache, pubsub, remote-client, and translate-pubsub), the generic dependencies region tags are removed entirely. I have no feedback to provide as there are no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/526729539
Removes duplicate and generic
dependenciesregion tags inappengine-java8samples'pom.xmlfiles. Renames the unique region tag used in devsite inendpoints-v2-skeleton/build.gradletoappengine_endpoints_gradle_dependenciesto specify the gradle tool/tech used.Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only