Skip to content

doc: Fix example for create_async_connector in the README#1301

Merged
hessjcg merged 2 commits into
GoogleCloudPlatform:mainfrom
lopuhin:patch-1
Sep 29, 2025
Merged

doc: Fix example for create_async_connector in the README#1301
hessjcg merged 2 commits into
GoogleCloudPlatform:mainfrom
lopuhin:patch-1

Conversation

@lopuhin

@lopuhin lopuhin commented May 30, 2025

Copy link
Copy Markdown
Contributor

An example is missing an await.

@kgala2

kgala2 commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

Hi @lopuhin, could you update the PR's title to fix: Update README to add await to create_async_connector()?

@hessjcg hessjcg changed the title Fix example for create_async_connector in the README docs:Fix example for create_async_connector in the README Sep 25, 2025
@hessjcg hessjcg changed the title docs:Fix example for create_async_connector in the README doc: Fix example for create_async_connector in the README Sep 25, 2025
@hessjcg

hessjcg commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

@lopuhin lopuhin changed the title doc: Fix example for create_async_connector in the README fix: Update README to add await to create_async_connector() Sep 25, 2025
@lopuhin lopuhin changed the title fix: Update README to add await to create_async_connector() doc: Fix example for create_async_connector in the README Sep 25, 2025
@lopuhin

lopuhin commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

sorry reverted the title to the original

@hessjcg

hessjcg commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

@hessjcg hessjcg merged commit 2385f4f into GoogleCloudPlatform:main Sep 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants