Skip to content

fix: Update README to add await to create_async_connector() call#1306

Closed
BurnzZ wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BurnzZ:fix-README
Closed

fix: Update README to add await to create_async_connector() call#1306
BurnzZ wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BurnzZ:fix-README

Conversation

@BurnzZ

@BurnzZ BurnzZ commented Jun 21, 2025

Copy link
Copy Markdown

A very small fix to the Asyncpg Connection Pool when I ran the code example.

@BurnzZ BurnzZ requested a review from a team as a code owner June 21, 2025 12:45
@kgala2

kgala2 commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

Thanks for catching this @BurnzZ, I will review this change shortly!

@kgala2 kgala2 changed the title fix README: add await to create_async_connector() call chore: add await to create_async_connector() call in README Jul 11, 2025
@kgala2 kgala2 changed the title chore: add await to create_async_connector() call in README fix README: add await to create_async_connector() call Jul 11, 2025
@hessjcg hessjcg changed the title fix README: add await to create_async_connector() call fix: Update README to add await to create_async_connector() call Jul 11, 2025
@BurnzZ

BurnzZ commented Jul 14, 2025

Copy link
Copy Markdown
Author

I just realized this is a duplicate of #1301.

Hey there @lopuhin! 👋 😄

@lopuhin

lopuhin commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Hey @BurnzZ glad to see you here and thanks for drawing attention to it 😄 We've been using the adapter with the databases library though a little custom adapter and it's working well for us

@kgala2

kgala2 commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

I just realized this is a duplicate of #1301.

Hey there @lopuhin! 👋 😄

Hey @BurnzZ, thanks for pointing out the duplicate PR! I appreciate you bringing that to our attention. After reviewing both, I've decided to merge @lopuhin's PR since it was submitted earlier. Thanks again for your help

@BurnzZ

BurnzZ commented Jul 19, 2025

Copy link
Copy Markdown
Author

After reviewing both, I've decided to merge @lopuhin's PR since it was submitted earlier. Thanks again for your help

Cheers for looking into it @kgala2! Closing this in favor of #1301.

We've been using the adapter with the databases library though a little custom adapter and it's working well for us

@lopuhin that's awesome! I've been using this on my side project 😄

@BurnzZ BurnzZ closed this Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants