refactor(plugins): move native plugins admincore/docmanager/storebrowser → plugins/#795
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
intel352
added a commit
to GoCodeAlone/workflow-registry
that referenced
this pull request
May 29, 2026
…, docmanager (#170) * feat(registry): track built-in native plugins admincore, storebrowser, docmanager These three built-in native plugins were relocated from plugin/ to plugins/ in the workflow engine (GoCodeAlone/workflow#795) and were previously untracked in the registry. Adds builtin manifests (type:builtin, tier:core, path:plugins/X) and regenerates v1/index.json. Audit confirmed these are the only engine-plugin gaps; the remaining unregistered workflow/plugins/* dirs (all, builder-*, registry-*) are wfctl-internal builder/registry-provider impls with no engine capabilities and stay intentionally untracked. * docs: regenerate README for new native-plugin manifests
intel352
added a commit
that referenced
this pull request
May 30, 2026
…ac (#797) Both packages have ZERO importers anywhere in the workflow ecosystem (verified across all workflow* repos + ratchet — only documentation mentions, no code): - plugin/community (SubmissionValidator/ReviewChecklist): plugin-submission validation tooling that was never wired. The workflow-registry repo does its own manifest validation (scripts/validate-manifests.sh + jsonschema), so this Go validator is redundant. - plugin/rbac (BuiltinProvider): an auth.PermissionProvider bridge over auth/rbac.PolicyEngine that was never registered with auth.PermissionManager (AddProvider is never called with a builtin in non-test code). Per the plugin/ consolidation design (#795) these were deferred from deletion pending an ecosystem check; that check found no home or use. Recoverable from git history if a builtin permission provider or submission validator is wanted later. Also drops the two stale rows in docs/API_STABILITY.md and the stale plugin/rbac references in scripts/audit-cloud-symbols.sh comments (the plugin/rbac/aws.go they named never existed). Historical docs/plans left intact. go build ./... + tests for plugin/plugins/cmd-server/auth pass; audit script still passes (plugin/rbac never imported aws-sdk-go-v2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates misfiled plugin implementations out of the
plugin/framework directory and intoplugins/(where built-in plugins live). Part 1 of the plugin/↔plugins/ consolidation (design: docs/plans/2026-05-29-plugin-dir-consolidation-design.md, passed adversarial-design-review).admincore,docmanager,storebrowserare NativePlugin implementations (registered viainit()→plugin.RegisterNativePluginFactory), not framework. Movedplugin/{admincore,docmanager,storebrowser}→plugins/; updated the 3 blank imports in cmd/server/main.go; fixed stale doc refs.Framework stays in
plugin/(loader, manager, manifest, sdk, builder, registry, external, installer, cosign, native). No registration-pattern change. Native-plugin activation remains via blank import in cmd/server/main.go (they're NativePlugins, not EnginePlugins, so not added to plugins/all which aggregates EnginePlugins).Follow-ups (separate PRs): AI providers relocated plugin/ai→ai/providers (move-only); workflow-registry manifests for the 3 moved plugins.
plugin/community+plugin/rbac(orphaned) deliberately deferred per adversarial review.Verified:
go build ./...+ tests for moved packages + plugin framework + cmd/server pass; native plugins still register.