chore(plugin): remove orphaned dead code plugin/community + plugin/rbac#797
Merged
Merged
Conversation
Both packages have ZERO importers anywhere in the workflow ecosystem (verified across all workflow* repos + ratchet — only documentation mentions, no code): - plugin/community (SubmissionValidator/ReviewChecklist): plugin-submission validation tooling that was never wired. The workflow-registry repo does its own manifest validation (scripts/validate-manifests.sh + jsonschema), so this Go validator is redundant. - plugin/rbac (BuiltinProvider): an auth.PermissionProvider bridge over auth/rbac.PolicyEngine that was never registered with auth.PermissionManager (AddProvider is never called with a builtin in non-test code). Per the plugin/ consolidation design (#795) these were deferred from deletion pending an ecosystem check; that check found no home or use. Recoverable from git history if a builtin permission provider or submission validator is wanted later. Also drops the two stale rows in docs/API_STABILITY.md and the stale plugin/rbac references in scripts/audit-cloud-symbols.sh comments (the plugin/rbac/aws.go they named never existed). Historical docs/plans left intact. go build ./... + tests for plugin/plugins/cmd-server/auth pass; audit script still passes (plugin/rbac never imported aws-sdk-go-v2).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the plugin/ consolidation by removing two orphaned packages deferred from #795 (the adversarial review flagged deleting them as scope-creep without an ecosystem check first).
Ecosystem check (done):
SubmissionValidator/ReviewChecklistandrbac.BuiltinProviderhave zero code importers anywhere across the workflow* repos + ratchet — only documentation mentions. No home/use found:plugin/communitysubmission-validation tooling is superseded by workflow-registry's ownvalidate-manifests.sh+ jsonschema.plugin/rbac.BuiltinProvider(auth.PermissionProvider bridge) is never registered withauth.PermissionManager(AddProvider never called with a builtin).Recoverable from git history if needed later. Drops stale refs in API_STABILITY.md + audit-cloud-symbols.sh comments; historical docs/plans left intact. Build + tests + audit script pass.