Register ghcr registry provider alias#614
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Registers the GitHub Container Registry (GHCR) provider under both github (back-compat) and ghcr (schema-validated) so wfctl registry login can use ci.registries[].type: ghcr, and adds a regression test for that alias.
Changes:
- Register the GHCR registry provider under both
githubandghcrprovider names. - Update the GHCR provider to support a configurable provider name.
- Add CLI test coverage for
wfctl registry loginusingtype: ghcr.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/registry-github/plugin.go | Registers GHCR provider under both github and ghcr via name-aware provider instances. |
| cmd/wfctl/registry_login_test.go | Adds a test ensuring runRegistryLogin works with ci.registries[].type: ghcr. |
Comment on lines
16
to
19
| func init() { | ||
| registry.Register(New()) | ||
| registry.Register(&GHCRProvider{name: "github"}) | ||
| registry.Register(&GHCRProvider{name: "ghcr"}) | ||
| } |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
githuband validatedghcrtype nameswfctl registry loginwithci.registries[].type: ghcrVerification
GOWORK=off go test ./plugins/registry-github ./cmd/wfctlGOWORK=off go test ./...Review
type: githubcompatibility while making the schema-acceptedtype: ghcrusable by wfctl; no credential handling behavior changed.