Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions cmd/wfctl/registry_login_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,28 @@ ci:
}
}

func TestRunRegistryLogin_GHCRAlias(t *testing.T) {
dir := t.TempDir()
content := `
ci:
registries:
- name: ghcr
type: ghcr
path: ghcr.io/myorg
auth:
env: GITHUB_TOKEN
`
cfgPath := filepath.Join(dir, "workflow.yaml")
if err := os.WriteFile(cfgPath, []byte(content), 0644); err != nil {
t.Fatalf("write fixture: %v", err)
}
t.Setenv("GITHUB_TOKEN", "test-token")

if err := runRegistryLogin([]string{"--config", cfgPath, "--registry", "ghcr", "--dry-run"}); err != nil {
t.Fatalf("runRegistryLogin ghcr alias: %v", err)
}
}

func TestRunRegistryLogin_UnknownRegistry(t *testing.T) {
dir := t.TempDir()
cfgPath := writeRegistryLoginFixture(t, dir)
Expand Down
16 changes: 12 additions & 4 deletions plugins/registry-github/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,24 @@ import (
)

func init() {
registry.Register(New())
registry.Register(&GHCRProvider{name: "github"})
registry.Register(&GHCRProvider{name: "ghcr"})
}
Comment on lines 16 to 19

// GHCRProvider implements registry.RegistryProvider for GitHub Container Registry.
type GHCRProvider struct{}
type GHCRProvider struct {
name string
}

// New returns a new GHCRProvider.
func New() registry.RegistryProvider { return &GHCRProvider{} }
func New() registry.RegistryProvider { return &GHCRProvider{name: "github"} }

func (g *GHCRProvider) Name() string { return "github" }
func (g *GHCRProvider) Name() string {
if g.name == "" {
return "github"
}
return g.name
}

func (g *GHCRProvider) Login(ctx registry.Context, cfg registry.ProviderConfig) error {
token, err := resolveToken(cfg)
Expand Down
Loading