-
Notifications
You must be signed in to change notification settings - Fork 1
ci: switch to self-hosted runners #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,7 @@ env: | |||||||
| jobs: | ||||||||
| test: | ||||||||
| name: Test (Go ${{ matrix.go-version }}) | ||||||||
| runs-on: ubuntu-latest | ||||||||
| runs-on: [self-hosted, Linux, X64] | ||||||||
| permissions: | ||||||||
| contents: read | ||||||||
| packages: read | ||||||||
|
|
@@ -67,7 +67,7 @@ jobs: | |||||||
|
|
||||||||
| lint: | ||||||||
| name: Lint | ||||||||
| runs-on: ubuntu-latest | ||||||||
| runs-on: [self-hosted, Linux, X64] | ||||||||
|
||||||||
| permissions: | ||||||||
| contents: read | ||||||||
| packages: read | ||||||||
|
|
@@ -104,7 +104,7 @@ jobs: | |||||||
|
|
||||||||
| build: | ||||||||
| name: Build | ||||||||
| runs-on: ubuntu-latest | ||||||||
| runs-on: [self-hosted, Linux, X64] | ||||||||
|
||||||||
| permissions: | ||||||||
| contents: read | ||||||||
| packages: read | ||||||||
|
|
@@ -153,7 +153,7 @@ jobs: | |||||||
|
|
||||||||
| ui-test: | ||||||||
| name: UI Tests | ||||||||
| runs-on: ubuntu-latest | ||||||||
| runs-on: [self-hosted, Linux, X64] | ||||||||
|
||||||||
| permissions: | ||||||||
| contents: read | ||||||||
| packages: read | ||||||||
|
|
@@ -190,7 +190,7 @@ jobs: | |||||||
| # 3. Engine loading (can BuildFromConfig produce a working engine?) | ||||||||
| example-configs: | ||||||||
| name: Validate Example Configs | ||||||||
|
||||||||
| name: Validate Example Configs | |
| name: Validate Example Configs | |
| if: github.event_name == 'push' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching this job to a self-hosted runner means the workflow (including
pull_requestruns) will execute arbitrary PR code on your own machine. If PRs can come from untrusted contributors (or even just non-admins), this is a high-risk escalation compared to GitHub-hosted runners; consider gating self-hosted usage (e.g., only onpush/protected branches, or with anif:condition that restricts to trusted actors/branches) or keeping PRs on GitHub-hosted runners.