ci: switch to self-hosted runners#351
Closed
intel352 wants to merge 2 commits into
Closed
Conversation
Replace ubuntu-latest with [self-hosted, Linux, X64] to use org's AM5GamingRig runner. Testing with CI workflow first before migrating remaining workflows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow to run all jobs on an organization self-hosted runner instead of GitHub-hosted ubuntu-latest, as a trial before broader migration.
Changes:
- Switched
runs-onfor all CI jobs fromubuntu-latestto[self-hosted, Linux, X64] - Applied consistently across
test,lint,build,ui-test, andexample-configs
| test: | ||
| name: Test (Go ${{ matrix.go-version }}) | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] |
There was a problem hiding this comment.
Switching this job to a self-hosted runner means the workflow (including pull_request runs) will execute arbitrary PR code on your own machine. If PRs can come from untrusted contributors (or even just non-admins), this is a high-risk escalation compared to GitHub-hosted runners; consider gating self-hosted usage (e.g., only on push/protected branches, or with an if: condition that restricts to trusted actors/branches) or keeping PRs on GitHub-hosted runners.
Suggested change
| runs-on: [self-hosted, Linux, X64] | |
| runs-on: [self-hosted, Linux, X64] | |
| if: github.event_name == 'push' |
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] |
There was a problem hiding this comment.
Switching this job to a self-hosted runner means the workflow (including pull_request runs) will execute arbitrary PR code on your own machine. If PRs can come from untrusted contributors (or even just non-admins), this is a high-risk escalation compared to GitHub-hosted runners; consider gating self-hosted usage (e.g., only on push/protected branches, or with an if: condition that restricts to trusted actors/branches) or keeping PRs on GitHub-hosted runners.
| build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] |
There was a problem hiding this comment.
Switching this job to a self-hosted runner means the workflow (including pull_request runs) will execute arbitrary PR code on your own machine. If PRs can come from untrusted contributors (or even just non-admins), this is a high-risk escalation compared to GitHub-hosted runners; consider gating self-hosted usage (e.g., only on push/protected branches, or with an if: condition that restricts to trusted actors/branches) or keeping PRs on GitHub-hosted runners.
| ui-test: | ||
| name: UI Tests | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] |
There was a problem hiding this comment.
Switching this job to a self-hosted runner means the workflow (including pull_request runs) will execute arbitrary PR code on your own machine. If PRs can come from untrusted contributors (or even just non-admins), this is a high-risk escalation compared to GitHub-hosted runners; consider gating self-hosted usage (e.g., only on push/protected branches, or with an if: condition that restricts to trusted actors/branches) or keeping PRs on GitHub-hosted runners.
| @@ -190,7 +190,7 @@ jobs: | |||
| # 3. Engine loading (can BuildFromConfig produce a working engine?) | |||
| example-configs: | |||
| name: Validate Example Configs | |||
There was a problem hiding this comment.
Switching this job to a self-hosted runner means the workflow (including pull_request runs) will execute arbitrary PR code on your own machine. If PRs can come from untrusted contributors (or even just non-admins), this is a high-risk escalation compared to GitHub-hosted runners; consider gating self-hosted usage (e.g., only on push/protected branches, or with an if: condition that restricts to trusted actors/branches) or keeping PRs on GitHub-hosted runners.
Suggested change
| name: Validate Example Configs | |
| name: Validate Example Configs | |
| if: github.event_name == 'push' |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestwith[self-hosted, Linux, X64]in CI workflowTest plan
🤖 Generated with Claude Code