Skip to content

test(iac): pin ComputePlanVersion=v2 regression-guard; release v1.2.1 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intel352 merged 1 commit into from
May 17, 2026
Merged

test(iac): pin ComputePlanVersion=v2 regression-guard; release v1.2.1 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions internal/iacserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,21 @@ func TestIaCServer_DetectDriftWithSpecs_DelegatesToDetectDrift(t *testing.T) {
t.Error("expected error from uninitialized provider")
}
}

// TestAWSIaCServer_Capabilities_ComputePlanVersionV2 pins the Phase 2
// contract signal: the plugin MUST declare ComputePlanVersion="v2" so
// wfctl routes via wfctlhelpers.ApplyPlanWithHooks (v2 dispatch).
// A silent regression that drops the literal would degrade to v1
// dispatch via wfctlhelpers.DispatchVersionFor's empty-default,
// breaking the Phase 2 hard-cutover contract per ADR 0024 + ADR 0040.
// Per workflow#640 + #695 Phase 2 + 2.5 cascade closeout.
func TestAWSIaCServer_Capabilities_ComputePlanVersionV2(t *testing.T) {
s := NewIaCServer()
resp, err := s.Capabilities(context.Background(), &pb.CapabilitiesRequest{})
if err != nil {
t.Fatalf("Capabilities: %v", err)
}
if got := resp.GetComputePlanVersion(); got != "v2" {
t.Errorf("CapabilitiesResponse.ComputePlanVersion = %q; want %q (v2 dispatch opt-in lost)", got, "v2")
}
}
Loading