test(iac): pin ComputePlanVersion=v2 regression-guard; release v1.2.1#20
Merged
Conversation
…e closeout) Adds TestAWSIaCServer_Capabilities_ComputePlanVersionV2 mirroring the existing gcp + DO equivalents. Pins the Phase 2 contract signal: a silent regression dropping the "v2" literal in Capabilities would degrade to v1 dispatch via wfctlhelpers.DispatchVersionFor's empty-default, breaking the Phase 2 hard-cutover contract per ADR 0024 + ADR 0040. Per workflow#640 + #695 Phase 2 + 2.5 cascade closeout. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a regression-guard test ensuring the AWS IaC server continues to declare ComputePlanVersion="v2" in its Capabilities response, preventing accidental fallback to v1 dispatch behavior.
Changes:
- Adds
TestAWSIaCServer_Capabilities_ComputePlanVersionV2. - Verifies
CapabilitiesResponse.ComputePlanVersionremains pinned to"v2".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per Phase 2 + 2.5 cascade closeout cleanup (Item 3 of
docs/plans/2026-05-17-phase2.5-cleanup-bundle-design.mdin workflow repo): adds the missingCapabilities() → ComputePlanVersion="v2"regression-guard test.Without this, a future refactor of the
Capabilitiesreturn literal could silently revert to v1 dispatch (empty ComputePlanVersion → wfctlhelpers.DispatchVersionFor empty-default) with no signal until production deploy fails.Matches the equivalent test in workflow-plugin-gcp (
TestGCPIaCServer_Capabilities_ComputePlanVersionV2at iacserver_test.go:67) and workflow-plugin-digitalocean (TestDOIaCServer_Capabilities_DeclaresV2at iacserver_finalize_test.go:192).Test-only change; cuts as v1.2.1 patch (no behavioral impact).
Test plan
go test ./internal/ -run TestAWSIaCServer_Capabilities_ComputePlanVersionV2 -v→ PASSgo test ./internal/ -race -count=1→ full package PASS race-cleanRollback
Revert commit. Test removal is non-functional.