Skip to content

⚡ Optimize string concatenation in discovery debug output #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GhostTypes merged 1 commit into from
Jan 20, 2026
Merged

⚡ Optimize string concatenation in discovery debug output #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions flashforge/discovery/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,26 +276,26 @@ def print_debug_info(self, response: bytes, ip_address: str) -> None:
# Hex dump
print("Hex dump:")
for i in range(0, len(response), 16):
line = f"{i:04x} "
parts = [f"{i:04x} "]

# Hex values
for j in range(16):
if i + j < len(response):
line += f"{response[i + j]:02x} "
parts.append(f"{response[i + j]:02x} ")
else:
line += " "
parts.append(" ")

if j == 7:
line += " "
parts.append(" ")

# ASCII representation
line += " "
parts.append(" ")
for j in range(16):
if i + j < len(response):
c = response[i + j]
line += chr(c) if 32 <= c <= 126 else '.'
parts.append(chr(c) if 32 <= c <= 126 else '.')

print(line)
print("".join(parts))

# ASCII dump
print("ASCII dump:")
Expand Down