β‘ Optimize string concatenation in discovery debug output #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What: Replaced repeated string concatenation (
+=) inside loops with list appending and"".join()in theprint_debug_infomethod ofFlashForgePrinterDiscovery.π― Why: String concatenation in Python creates a new string object for each addition, which is inefficient (O(n^2)) for building large strings in loops. Using a list of strings and joining them at the end is O(n) and much more memory efficient.
π Measured Improvement:
PR created automatically by Jules for task 9065868647554307597 started by @GhostTypes