Skip to content

Update description of MIXS:0000127 in mixs.yaml#987

Open
only1chunts wants to merge 1 commit intomainfrom
issue986-MIXS0000127-description-update
Open

Update description of MIXS:0000127 in mixs.yaml#987
only1chunts wants to merge 1 commit intomainfrom
issue986-MIXS0000127-description-update

Conversation

@only1chunts
Copy link
Member

close #986

@only1chunts only1chunts requested a review from mslarae13 June 18, 2025 13:09
@github-actions
Copy link
Contributor

LinkML Linting Results

Summary

Count
Schemas Checked 1
Schemas with Error 1
Schemas with Warning 0
Total Errors 13
Total Warnings 0

Problems per Schema

/home/runner/work/mixs/mixs/src/mixs/schema/mixs.yaml

Errors

  • recommended: Subset 'combination_classes' does not have recommended slot 'description'
  • recommended: Subset 'sequencing' does not have recommended slot 'description'
  • recommended: Subset 'environment' does not have recommended slot 'description'
  • recommended: Subset 'nucleic acid sequence source' does not have recommended slot 'description'
  • recommended: Subset 'investigation' does not have recommended slot 'description'
  • standard_naming: Slot has name 'HACCP_term'
  • standard_naming: Slot has name 'IFSAC_category'
  • standard_naming: Slot has name 'air_PM_concen'
  • standard_naming: Slot has name 'ferm_pH'
  • standard_naming: Slot has name 'microb_start_taxID'
  • standard_naming: Slot has name 'soil_pH'
  • standard_naming: Slot has name 'spikein_AMR'
  • standard_naming: Slot has name 'water_pH'

@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://GenomicsStandardsConsortium.github.io/mixs/pr-preview/pr-987/

Built to branch gh-pages at 2025-06-18 13:13 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

characteristics. In crude oil a high pour point is generally associated with
characteristics. In crude oil a high pour point is generally associated with
a high paraffin content, typically found in crude deriving from a larger proportion
of plant material. (soure: https://en.wikipedia.org/wiki/pour_point)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's a specific LinkML slot for definition sources. Looking now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do: can we move the wikipedia page link to the appropriate metaslot for this slot see_also

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below

characteristics. In crude oil a high pour point is generally associated with
characteristics. In crude oil a high pour point is generally associated with
a high paraffin content, typically found in crude deriving from a larger proportion
of plant material. (soure: https://en.wikipedia.org/wiki/pour_point)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of plant material. (soure: https://en.wikipedia.org/wiki/pour_point)'
of plant material.'
see_also:
- https://en.wikipedia.org/wiki/pour_point

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

characteristics. In crude oil a high pour point is generally associated with
characteristics. In crude oil a high pour point is generally associated with
a high paraffin content, typically found in crude deriving from a larger proportion
of plant material. (soure: https://en.wikipedia.org/wiki/pour_point)'
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description still contains a typo in the citation label: "(soure: ...)" should be "(source: ...)" to match the intended fix for MIXS:0000127 / issue #986.

Suggested change
of plant material. (soure: https://en.wikipedia.org/wiki/pour_point)'
of plant material. (source: https://en.wikipedia.org/wiki/pour_point)'

Copilot uses AI. Check for mistakes.
@turbomam
Copy link
Member

I requested Copilot reviews here because I’m helping triage/review MIxS PRs, not because I authored them. If you have the same GitHub permissions and Copilot access, you can do the same on any PR. You’ll know you’re enabled if you can see the Copilot review option in the PR review UI or related actions; if not, you likely need org/repo access and a Copilot seat or feature enablement from the repo or GitHub org admins.

@turbomam
Copy link
Member

We've requested a GitHub Copilot review on this PR as part of a pass across all open MixS PRs. Copilot catches things like unused imports, resource leaks, and naming inconsistencies — it's a lightweight first pass, not a substitute for human review. No action needed from you unless Copilot flags something you agree with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pour point: definition has a typo in "soure"

4 participants