Document release workflow in edit_workflow.md#1090
Conversation
|
Suggested Addition: Tag Naming WarningBased on issues encountered during the v6.2.3 release (see #1104), this documentation should include a warning about tag naming conventions. Suggested text to add after the parameters section:
This would help prevent the confusion that occurred when |
Fills in the empty "# Releases" section with: - How to trigger the automated release workflow - What the workflow does - Pre-merge checklist for reviewers - Post-merge steps for publishing releases - Release publishing permissions - Versioning guidance (semver) Addresses feedback from @mslarae13 on PR #1088. Closes #120. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
88f265b to
debf606
Compare
|
Rebase & cross-reference note (2026-03-10) This PR was rebased onto current Dependency: #1115 should merge before this PR. That PR changes the release workflow parameters to a unified
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `skip_tests`: Optional, for faster iteration during development | ||
| 4. Click **Run workflow** | ||
|
|
||
| The workflow will: | ||
| - Bump version numbers in `pyproject.toml`, `CITATION.cff`, `.zenodo.json`, and `release/README.md` | ||
| - Run the full build and test suite |
There was a problem hiding this comment.
The text says the workflow "will" run the full build and test suite, but the workflow has a skip_tests input that runs make ... all without test when set. Please reword this section to describe the conditional behavior (tests run unless skip_tests is true).
| - `skip_tests`: Optional, for faster iteration during development | |
| 4. Click **Run workflow** | |
| The workflow will: | |
| - Bump version numbers in `pyproject.toml`, `CITATION.cff`, `.zenodo.json`, and `release/README.md` | |
| - Run the full build and test suite | |
| - `skip_tests`: Optional, for faster iteration during development; when set, skips running the test suite | |
| 4. Click **Run workflow** | |
| The workflow will: | |
| - Bump version numbers in `pyproject.toml`, `CITATION.cff`, `.zenodo.json`, and `release/README.md` | |
| - Run the full build and, unless `skip_tests` is true, the test suite |
There was a problem hiding this comment.
Valid — good catch. The doc says "Run the full build and test suite" unconditionally, but the workflow (lines 108–114) has two branches: make install clean all test when skip_tests is false, and make install clean all when true. The text here should reflect that the test suite is conditional.
Will update this line to say something like "Run the full build and, unless skip_tests is true, the test suite" as you suggest.
|
|
||
| ### Pre-merge Checklist | ||
| - [ ] Review version numbers are correct | ||
| - [ ] Review schema diff for unexpected changes (see `assets/diff_results/schema_comparison_results.yaml`) |
There was a problem hiding this comment.
This doc points reviewers to assets/diff_results/schema_comparison_results.yaml, but the workflow intentionally does not fail if diff generation errors (|| echo ...), which can leave this file missing or incomplete. Consider adding a note that reviewers should also check the Actions logs if the diff file isn't present/looks incomplete.
| - [ ] Review schema diff for unexpected changes (see `assets/diff_results/schema_comparison_results.yaml`) | |
| - [ ] Review schema diff for unexpected changes (see `assets/diff_results/schema_comparison_results.yaml`). If this file is missing or looks incomplete, open the corresponding workflow run in GitHub Actions and review the logs for any schema diff generation errors. |
There was a problem hiding this comment.
Valid. The workflow uses || echo "Diff generation encountered issues - check logs" (line 129 of the workflow YAML), which means the diff step will silently succeed even if the actual diff tool errors out. The output file could end up missing or incomplete with no signal in the PR itself.
Adding a reviewer-facing note as you suggest is a good low-cost fix. We could also consider failing the workflow on diff errors and making the || echo fallback opt-in, but that's a separate discussion — the doc fix is worth doing either way.
| Users with release publishing permission: | ||
| - **Admins**: @lschriml, @only1chunts | ||
| - **Maintain**: @sujaypatil96, @turbomam | ||
|
|
There was a problem hiding this comment.
Listing specific GitHub usernames/roles for release publishing permissions is likely to become stale as repo permissions change. Consider referencing a GitHub team (or a link/instruction to check the repository "Manage access" settings) instead of hard-coding individual accounts in this doc.
| Users with release publishing permission: | |
| - **Admins**: @lschriml, @only1chunts | |
| - **Maintain**: @sujaypatil96, @turbomam | |
| Release publishing is restricted to users with **Admin** or **Maintain** access on the repository. | |
| To see who currently has these permissions, open the GitHub repository and go to **Settings → Collaborators and teams** (or **Settings → Manage access**). |
There was a problem hiding this comment.
Valid. Hard-coding GitHub usernames will go stale as repo membership changes. Pointing to Settings > Collaborators and teams (or referencing a GitHub team) is more maintainable.
Will replace the username list with a reference to the repo's access settings, similar to your suggestion.
- Clarify that tests run conditionally (unless skip_tests is true) - Add note about checking Actions logs when diff file is missing - Replace hardcoded usernames with reference to repo role-based permissions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Somehow this didn't make it into the 6.2.2 release... I think Claude and I edited the file in
docs/when it really should have gone insrc/docs.docs/is gitignored.Summary
# Releasessection insrc/docs/edit_workflow.mdDetails
This PR addresses feedback from @mslarae13 on PR #1088 regarding documenting the release process.
The new documentation covers:
Closes #120
🤖 Generated with Claude Code