Horsemanship by TheThanathor · Pull Request #1138 · Gamemode4Dev/GM4_Datapacks

TheThanathor · 2025-06-08T19:02:40Z

Level up your horses by using them to improve their health, speed and jump strength

Full module description will be added soon once the design is more finalized

TheThanathor · 2025-11-04T21:34:23Z

Ready for review, but needs textures and the pack.png before merging

runcows · 2025-11-04T21:38:56Z

Also probably want to update the README to not be shapeless portals copy 😅

runcows

Partial Review. I didn't get through a lot of the functions, but I figured something is better than nothing :D

gm4_horsemanship/data/gm4_horsemanship/recipe/horse_wings.json

gm4_horsemanship/README.md

gm4_horsemanship/beet.yaml

gm4_horsemanship/assets/translations.csv

gm4_horsemanship/data/gm4_horsemanship/advancement/feed_horse.json

...rsemanship/data/gm4_horsemanship/function/horse_processing/food/type/chorus_fruit.mcfunction

...ship/data/gm4_horsemanship/function/horse_processing/food/feed_added_food_untamed.mcfunction

gm4_horsemanship/data/gm4_horsemanship/function/horse_processing/start_riding_horse.mcfunction

...semanship/data/gm4_horsemanship/function/horse_processing/food/feed_original_food.mcfunction

gm4_horsemanship/data/gm4_horsemanship/function/horse_processing/food/add_age.mcfunction

runcows · 2026-01-22T08:48:45Z

gm4_guidebook/triggers.json

  "heart_canisters": 15,
  "helious_shamir": 69,
  "holographic_tags": 94,
+  "horsemanship": 122,


122 is taken by lavish livestock right now.
On main branch currently, "__next__": 124

misode

I've just had a go testing this module in-game. I don't think this is mergeable right now.

There doesn't seem to be any documentation of its features (wiki, readme, guidebook) meaning you have to read the code in order to know what to feed your horse.
From some quick survival testing, it doesn't seem very fun? The initial speed of your horse is reduced a ton meaning you have to spend a lot of time just slowly riding your horse before it becomes useful.
The level and stamina systems are not very visible, I had to cheat and look at the scoreboards to make any sense of it.

runhorse if you will

- removed Stamina mechanics - updated Guidebook entries - level 0 horses have higher stats (level 15 horses remain the same)

Bloo-dev

Full review. I mostly found some minor format issues.

gm4_horsemanship/data/gm4_horsemanship/function/horse_processing/glider/wing/init.mcfunction

gm4_horsemanship/data/gm4/advancement/horse_takes_flight.json

.../data/gm4_horsemanship/function/horse_processing/glider/wing/calculate_wing_pitch.mcfunction

gm4_horsemanship/data/gm4_horsemanship/function/horse_processing/glider/wing/update.mcfunction

Bloo-dev · 2026-02-22T10:54:00Z

gm4_horsemanship/data/gm4_horsemanship/function/horse_processing/graze/tick.mcfunction

+# schedule from horse_processing/graze/start
+# schedule from here
+
+execute as @e[type=#gm4_horsemanship:trainable,tag=gm4_horse.grazing,nbt={EatingHaystack:0b}] at @s run function gm4_horsemanship:horse_processing/graze/complete


So as I understand this you start a 1t clock the moment you detect a grazing horse until it stops grazing. I guess that is the only way to detect that, but the nbt check on a 20Hz is making me uncomfortable.

gm4_horsemanship/beet.yaml

gm4_horsemanship/data/gm4_horsemanship/tags/block/can_eat_through.json

Bloo-dev · 2026-02-28T08:43:34Z

This PR currently does not merge due to an issue with Guidebook:
If a recipe defines a non-vanilla item tag or a non-required entry in an item tag, the Guidebook can not generate the recipe for it.

The clean way to fix this is to make PR which fixes the Guidebook logic. The dirty way is to just show a single, specific, horse armor in the horse wing recipe for now.

Bloo-dev · 2026-02-28T13:29:07Z

With #1276 merged this no longer errors. (once rebased)

runcows · 2026-03-18T14:43:53Z

gm4_horsemanship/data/gm4_horsemanship/recipe/horse_wings.json

+                "shearing_sound": "minecraft:item.horse_armor.unequip",
+                "slot": "body"
+            },
+            "minecraft:custom_model_data": "item/horse_wings",


Since this PR has been retargeted at 26.1, this is no longer valid.

Suggested change

"minecraft:custom_model_data": "item/horse_wings",

"minecraft:custom_model_data": {"strings":["gm4_horsemanship:item/horse_wings"]},

runcows · 2026-03-18T14:44:01Z

gm4_horsemanship/data/gm4/advancement/horse_takes_flight.json

+        "icon": {
+            "id": "minecraft:elytra",
+            "components": {
+                "minecraft:custom_model_data": "item/horse_wings"


Same issue here

misode added the submission A new community submitted module, not yet concept-accepted label Jun 9, 2025

TheThanathor marked this pull request as ready for review November 4, 2025 21:16

misode added the needs-testing Requires in-game testing label Nov 4, 2025

runcows reviewed Nov 6, 2025

View reviewed changes

runcows reviewed Jan 22, 2026

View reviewed changes

runcows mentioned this pull request Jan 22, 2026

Towering Trees #1228

Merged

misode reviewed Jan 25, 2026

View reviewed changes

TheThanathor and others added 21 commits February 22, 2026 11:32

update old module to 1.21.5

583e4b3

add swimming with rider

8f30a9f

fix horse breeding, add varying scales

17dead4

update horse training mechanics

3713f87

add more sounds and particles

d9a2d20

swap carrot to standard foods

2eaa554

update and simplify Horsemanship

a3010bf

update headers and reorganize folders

3295814

update horse flight

fac65b4

quick wing period fix

2f20a9b

runcow's horse improvements

e93277f

runhorse if you will

add horse wing texture (WIP)

35e936c

fix the wings!

5fda619

oops missing tag

7bffc08

add advancement, image and website note

ba28233

update to 1.21.11

6eca354

add translations

16c1923

technically RP is not required rn

3c43455

Backport mob_griefing gamerule

1ff263d

update Horsemanship

9d48c0e

- removed Stamina mechanics - updated Guidebook entries - level 0 horses have higher stats (level 15 horses remain the same)

update guidebook trigger

5d9a239

TheThanathor added 2 commits February 22, 2026 11:32

fix horse jumping

a7cde9e

fix attribuite names

856ada2

TheThanathor force-pushed the horsemanship branch from 205ed14 to 856ada2 Compare February 22, 2026 10:33

TheThanathor changed the base branch from master to update-26.1 February 22, 2026 10:34

fix guidebook trigger, remove plugin change

12fd25b

Bloo-dev requested changes Feb 22, 2026

View reviewed changes

TheThanathor added 2 commits February 22, 2026 12:55

resolve bloo's comments

b093a2c

fix last missing attribute

53f188d

BPR02 mentioned this pull request Feb 28, 2026

Improve Guidebook Item Resolver #1276

Merged

runcows suggested changes Mar 18, 2026

View reviewed changes

	"minecraft:custom_model_data": "item/horse_wings",
	"minecraft:custom_model_data": {"strings":["gm4_horsemanship:item/horse_wings"]},

Uh oh!

Conversation

TheThanathor commented Jun 8, 2025

Uh oh!

TheThanathor commented Nov 4, 2025

Uh oh!

runcows commented Nov 4, 2025

Uh oh!

runcows left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

runcows Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

misode left a comment

Choose a reason for hiding this comment

Uh oh!

Bloo-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bloo-dev Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Bloo-dev commented Feb 28, 2026

Uh oh!

Bloo-dev commented Feb 28, 2026

Uh oh!

runcows Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

runcows Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

runcows Jan 22, 2026 •

edited

Loading