Merged
Conversation
misode
added
submission
Member
Author
|
Vanilla 2x2 Dark oak is currently broken (and probably the other vanilla 2x2 as well) Mangrove roots need to check each block, not rely on the sapling Mangrove propagules are deleted when 1x1 fails to grow |
- add image - fix 2x2 vanilla trees - fix mangrove roots and saplings - add Lune to credits and contributors.json - add some missing headers
runcows
suggested changes
Jan 16, 2026
Contributor
runcows
left a comment
runcows
left a comment
There was a problem hiding this comment.
Prelim review. I did not look at a majority of the function logic in this module or even the generate plugin, I was mostly focused on more obvious things for right now
gm4_towering_trees/data/gm4_towering_trees/guidebook/towering_trees.json
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/guidebook/expanded_trees.json
Outdated
Show resolved
Hide resolved
lib_trees/data/gm4_trees/function/sapling/resolve_place_sapling.mcfunction
Outdated
Show resolved
Hide resolved
lib_trees/data/gm4_trees/function/sapling/advance_stage.mcfunction
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/guidebook/expanded_trees.json
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/tags/block/tree_placeable.json
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/tags/block/mangrove_root_replaceable.json
Outdated
Show resolved
Hide resolved
Bloo-dev
reviewed
Jan 16, 2026
Bloo-dev
reviewed
Jan 16, 2026
gm4_towering_trees/data/gm4_towering_trees/function/verify/initialize_sapling.mcfunction
Show resolved
Hide resolved
| execute if block ~ ~ ~ pale_oak_sapling run summon marker ~ ~ ~ {CustomName:"gm4_pale_oak_tree_sapling",Tags:["gm4_tree_sapling","gm4_towering_trees_sapling","gm4_pale_oak_tree_sapling","smithed.entity","smithed.strict","smithed.block"]} | ||
| execute if block ~ ~ ~ mangrove_propagule run summon marker ~ ~ ~ {CustomName:"gm4_mangrove_tree_sapling",Tags:["gm4_tree_sapling","gm4_towering_trees_sapling","gm4_mangrove_tree_sapling","smithed.entity","smithed.strict","smithed.block"]} | ||
| # set stage requirement (higher = longer to grow) | ||
| scoreboard players set @e[type=marker,tag=gm4_towering_trees_sapling,distance=..0.1] gm4_sap_growth 2 |
Member
There was a problem hiding this comment.
Could a limit=1 be inserted here?
Member
Author
There was a problem hiding this comment.
most likely, but technically it might break if there's already a marker there? Apple trees doesn't use a limit=1, not sure if that's because it was decided not to or because it was missed
Member
|
Tested in game, works as expected. I did not manage to break it by trying to obstruct the saplings. A note on features: |
Bloo-dev
added
tested
runcows
reviewed
Jan 22, 2026
…into pr/TheThanathor/1228
misode
approved these changes
Jan 26, 2026
Member
misode
left a comment
misode
left a comment
There was a problem hiding this comment.
This has been tested before. Birch structure can be shrunk down in the future.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
* add module * build for guidebook * add support for all mega trees * ah but use roots instead of glass * add all the trees \0oO/ * add credits * update contributor credits * finish final changes - add image - fix 2x2 vanilla trees - fix mangrove roots and saplings - add Lune to credits and contributors.json - add some missing headers * undo Thanathor > Djones in other modules / contributors.json * runcow comments * use as_integer method * unchange the formatting of contributors.json * Update guidebook triggers --------- Co-authored-by: Misode <misoloo64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mega / normal variants to all vanilla saplings
Also updates lib_trees to support this module
Note that this does not currently add giant bamboo or azalea, as those are not grown from saplings