Skip to content

feat(workflow-executor): add info logging around step execution#1514

Merged
Scra3 merged 4 commits intofeat/prd-214-setup-workflow-executor-packagefrom
feat/workflow-executor-info-logging
Mar 30, 2026
Merged

feat(workflow-executor): add info logging around step execution#1514
Scra3 merged 4 commits intofeat/prd-214-setup-workflow-executor-packagefrom
feat/workflow-executor-info-logging

Conversation

@Scra3
Copy link
Copy Markdown
Member

@Scra3 Scra3 commented Mar 26, 2026

Summary

  • Add info level to Logger interface
  • Log step execution start (runId, stepId, stepType, collection) and completion (status) in BaseStepExecutor.execute()
  • Update ConsoleLogger with structured JSON info logs
  • Update all test logger mocks to include info

Test plan

  • 320 tests pass
  • Lint + tsc clean

🤖 Generated with Claude Code

Note

Add info-level logging to BaseStepExecutor.execute for step start and completion

Adds two info-level log statements in BaseStepExecutor.execute: one at step start (logging runId, stepId, stepIndex, stepType, and base collection name) and one on successful completion (logging outcome status). Logger.info is also promoted from optional to required in the Logger interface, with all test mock loggers updated accordingly.

Macroscope summarized 7802ae3.

@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 26, 2026

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 20): execute 1

@Scra3 Scra3 force-pushed the feat/workflow-executor-info-logging branch from 96c6af0 to ef890a6 Compare March 26, 2026 14:53
@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 26, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
packages/workflow-executor/src/executors/base-step-executor.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

alban bertolini and others added 3 commits March 27, 2026 14:22
Add info level to Logger interface. Log step execution start (with
context: runId, stepId, stepType, collection) and completion (with
status) around doExecute in BaseStepExecutor.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tdown

- Remove duplicate info method in Logger interface and ConsoleLogger
- Update console-logger test to match console.log implementation with level field
- Add missing info mock in database-store tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matthv matthv force-pushed the feat/workflow-executor-info-logging branch from b30026e to 31cdb47 Compare March 27, 2026 14:01
…eLogger

console.log (info) vs console.error (error) already distinguishes the
level via stdout/stderr. The JSON level field is redundant — users who
need it can implement their own Logger.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Scra3 Scra3 force-pushed the feat/workflow-executor-info-logging branch from 82effcb to 7802ae3 Compare March 27, 2026 16:35
@Scra3 Scra3 merged commit df7e43a into feat/prd-214-setup-workflow-executor-package Mar 30, 2026
30 checks passed
@Scra3 Scra3 deleted the feat/workflow-executor-info-logging branch March 30, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants