feat(workflow-executor): add info logging around step execution (#1514)

Author: Scra3

packages/workflow-executor/src/executors/base-step-executor.ts

@@ -35,8 +35,27 @@ export default abstract class BaseStepExecutor<TStep extends StepDefinition = St
   }
 
   async execute(): Promise<StepExecutionResult> {
+    const { runId, stepId, stepIndex, stepDefinition, baseRecordRef } = this.context;
+
+    this.context.logger.info('Step execution started', {
+      runId,
+      stepId,
+      stepIndex,
+      stepType: stepDefinition.type,
+      collection: baseRecordRef.collectionName,
+    });
+
     try {
-      return await this.doExecute();
+      const result = await this.doExecute();
+
+      this.context.logger.info('Step execution completed', {
+        runId,
+        stepId,
+        stepIndex,
+        status: result.stepOutcome.status,
+      });
+
+      return result;
     } catch (error) {
       if (error instanceof WorkflowExecutorError) {
         if (error.cause !== undefined) {

packages/workflow-executor/src/ports/logger-port.ts

@@ -1,4 +1,4 @@
 export interface Logger {
   error(message: string, context: Record<string, unknown>): void;
-  info?(message: string, context: Record<string, unknown>): void;
+  info(message: string, context: Record<string, unknown>): void;
 }

packages/workflow-executor/test/executors/base-step-executor.test.ts

@@ -87,7 +87,7 @@ function makeMockRunStore(stepExecutions: StepExecutionData[] = []): RunStore {
 }
 
 function makeMockLogger(): Logger {
-  return { error: jest.fn() };
+  return { info: jest.fn(), error: jest.fn() };
 }
 
 function makeContext(overrides: Partial<ExecutionContext> = {}): ExecutionContext {

packages/workflow-executor/test/executors/condition-step-executor.test.ts

@@ -69,7 +69,7 @@ function makeContext(
     },
     schemaCache: new SchemaCache(),
     previousSteps: [],
-    logger: { error: jest.fn() },
+    logger: { info: jest.fn(), error: jest.fn() },
     ...overrides,
   };
 }

packages/workflow-executor/test/executors/load-related-record-step-executor.test.ts

@@ -140,7 +140,7 @@ function makeContext(
     },
     schemaCache: new SchemaCache(),
     previousSteps: [],
-    logger: { error: jest.fn() },
+    logger: { info: jest.fn(), error: jest.fn() },
     ...overrides,
   };
 }
@@ -1295,7 +1295,7 @@ describe('LoadRelatedRecordStepExecutor', () => {
     });
 
     it('returns user message and logs cause when agentPort.getRelatedData throws an infra error', async () => {
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const agentPort = makeMockAgentPort();
       (agentPort.getRelatedData as jest.Mock).mockRejectedValue(new Error('DB connection lost'));
       const mockModel = makeMockModel({ relationName: 'Order', reasoning: 'test' });

packages/workflow-executor/test/executors/mcp-task-step-executor.test.ts

@@ -107,7 +107,7 @@ function makeContext(
     },
     schemaCache: new SchemaCache(),
     previousSteps: [],
-    logger: { error: jest.fn() },
+    logger: { info: jest.fn(), error: jest.fn() },
     ...overrides,
   };
 }
@@ -218,7 +218,7 @@ describe('McpTaskStepExecutor', () => {
           tool_calls: [{ name: 'send_notification', args: { message: 'Hi' }, id: 'call_1' }],
         })
         .mockResolvedValueOnce({ tool_calls: [] });
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const runStore = makeMockRunStore();
       const context = makeContext({
         model,
@@ -299,7 +299,7 @@ describe('McpTaskStepExecutor', () => {
 
     it('returns error when saveStepExecution fails (Branch C)', async () => {
       const { model } = makeMockModel('send_notification', { message: 'Hello' });
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const runStore = makeMockRunStore({
         saveStepExecution: jest.fn().mockRejectedValue(new Error('DB unavailable')),
       });
@@ -491,7 +491,7 @@ describe('McpTaskStepExecutor', () => {
         invoke: invokeFn,
       });
       const { model } = makeMockModel('send_notification', { message: 'Hello' });
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const runStore = makeMockRunStore({
         saveStepExecution: jest.fn().mockRejectedValue(new Error('Disk full')),
       });
@@ -529,7 +529,7 @@ describe('McpTaskStepExecutor', () => {
           userConfirmed: true,
         },
       };
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const runStore = makeMockRunStore({
         getStepExecutions: jest.fn().mockResolvedValue([execution]),
         saveStepExecution: jest.fn().mockRejectedValue(new Error('Disk full')),
@@ -638,7 +638,7 @@ describe('McpTaskStepExecutor', () => {
         invoke: invokeFn,
       });
       const { model } = makeMockModel('send_notification', {});
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const context = makeContext({
         model,
         stepDefinition: makeStep({ automaticExecution: true }),

packages/workflow-executor/test/executors/read-record-step-executor.test.ts

@@ -129,7 +129,7 @@ function makeContext(
     },
     schemaCache: new SchemaCache(),
     previousSteps: [],
-    logger: { error: jest.fn() },
+    logger: { info: jest.fn(), error: jest.fn() },
     ...overrides,
   };
 }
@@ -668,7 +668,7 @@ describe('ReadRecordStepExecutor', () => {
     });
 
     it('returns user message and logs cause when agentPort.getRecord throws an infra error', async () => {
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const agentPort = makeMockAgentPort();
       (agentPort.getRecord as jest.Mock).mockRejectedValue(new Error('DB connection lost'));
       const mockModel = makeMockModel({ fieldNames: ['email'] });

packages/workflow-executor/test/executors/trigger-record-action-step-executor.test.ts

@@ -128,7 +128,7 @@ function makeContext(
     },
     schemaCache: new SchemaCache(),
     previousSteps: [],
-    logger: { error: jest.fn() },
+    logger: { info: jest.fn(), error: jest.fn() },
     ...overrides,
   };
 }
@@ -518,7 +518,7 @@ describe('TriggerRecordActionStepExecutor', () => {
     });
 
     it('returns user message and logs cause when agentPort.executeAction throws an infra error', async () => {
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const agentPort = makeMockAgentPort();
       (agentPort.executeAction as jest.Mock).mockRejectedValue(new Error('DB connection lost'));
       const mockModel = makeMockModel({

packages/workflow-executor/test/executors/update-record-step-executor.test.ts

@@ -130,7 +130,7 @@ function makeContext(
     },
     schemaCache: new SchemaCache(),
     previousSteps: [],
-    logger: { error: jest.fn() },
+    logger: { info: jest.fn(), error: jest.fn() },
     ...overrides,
   };
 }
@@ -681,7 +681,7 @@ describe('UpdateRecordStepExecutor', () => {
     });
 
     it('returns user message and logs cause when agentPort.updateRecord throws an infra error', async () => {
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const agentPort = makeMockAgentPort();
       (agentPort.updateRecord as jest.Mock).mockRejectedValue(new Error('DB connection lost'));
       const mockModel = makeMockModel({

packages/workflow-executor/test/http/executor-http-server.test.ts

@@ -45,7 +45,7 @@ function createServer(
   overrides: {
     runner?: Runner;
     workflowPort?: WorkflowPort;
-    logger?: { error: jest.Mock };
+    logger?: { info: jest.Mock; error: jest.Mock };
   } = {},
 ) {
   return new ExecutorHttpServer({
@@ -252,7 +252,7 @@ describe('ExecutorHttpServer', () => {
     });
 
     it('returns 503 when hasRunAccess throws', async () => {
-      const logger = { error: jest.fn() };
+      const logger = { info: jest.fn(), error: jest.fn() };
       const workflowPort = createMockWorkflowPort({
         hasRunAccess: jest.fn().mockRejectedValue(new Error('orchestrator down')),
       });