Skip to content

feat: Add Insights support with get-features and call-tool/read-resource methods#226

Merged
Steve-Mcl merged 3 commits into
mainfrom
209-insights-support
Jul 1, 2026
Merged

feat: Add Insights support with get-features and call-tool/read-resource methods#226
Steve-Mcl merged 3 commits into
mainfrom
209-insights-support

Conversation

@Steve-Mcl

Copy link
Copy Markdown
Contributor

Description

Adds forge -> driver passthrough functions to support Insights operations get MCP features, call MCP tool, read MCP resource.

Related Issue(s)

closes #209

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from hardillb June 25, 2026 20:07
@Steve-Mcl

Copy link
Copy Markdown
Contributor Author

For reference:

getMCPFeatures

  • is called from the forge app as app.containers.getMCPFeatures(instance, instanceWithMCPServers.mcpServers) see code in PR 7604
  • and this drivers handler forwards this to the launcher here as part of PR 571

callMCPTool

  • is called from the forge app as commandMethod(instance, endpoint, ...commandData) see code in PR 7604
  • and this drivers handler forwards this to the launcher here as part of PR 571

readMCPResource

  • is called from the forge app as commandMethod(instance, endpoint, ...commandData) see code in PR 7604
  • and this drivers handler forwards this to the launcher here as part of PR 571

@hardillb hardillb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at the endpoint URL selection, looks ok

@Steve-Mcl

Copy link
Copy Markdown
Contributor Author

@cstns can you give the docker driver changes a quick eye too please.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new driver passthrough methods to support “Insights”/MCP operations by proxying requests from Forge to the launcher’s /flowforge/command endpoint.

Changes:

  • Added JSDoc typedefs for MCP endpoint specification and access tokens.
  • Added getMCPFeatures, callMCPTool, and readMCPResource methods that forward MCP commands to the project container’s command endpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker.js
Comment thread docker.js Outdated
Comment thread docker.js
@Steve-Mcl

Copy link
Copy Markdown
Contributor Author

@cstns acted on initial feedback

Will raise PRs for localfs and l8s drivers to keep them in sync (once this is approved
)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Comment thread docker.js
Comment thread docker.js
Comment thread docker.js
Comment thread docker.js
Comment thread docker.js
@Steve-Mcl Steve-Mcl merged commit cb327db into main Jul 1, 2026
4 checks passed
@Steve-Mcl Steve-Mcl deleted the 209-insights-support branch July 1, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Expert Insights [diver-docker]

4 participants