Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .gemini/config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
have_fun: false

ignore_patterns: []

memory_config:
disabled: false

code_review:
disable: false
comment_severity_threshold: HIGH
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the non-default, the default is MEDIUM.

max_review_comments: -1
pull_request_opened:
help: false
summary: false
code_review: false
include_drafts: false
Comment on lines +12 to +16
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaults here are as per the following suggestion (to show the diff, not to be committed)

Suggested change
pull_request_opened:
help: false
summary: false
code_review: false
include_drafts: false
pull_request_opened:
help: false
summary: false
code_review: true
include_drafts: true

I've chosen to turn off all automated PR reviews in favour of using the manual review option, at least to begin with.

31 changes: 31 additions & 0 deletions .gemini/styleguide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
### PR009: Submit all comments as a single batch review

Use GitHub's "Start a review" → "Submit review" workflow. Avoid posting individual comments one at a time.

> *One notification with full context beats a drip-feed of pings. The author sees the complete picture and can plan their work.*

### PR010: Label comments by intent

Some review comments don’t have to be addressed.

Be sure to clearly communicate this to the PR author, for example, by using a “suggestion:” or “nitpick:” prefix. There’s a more detailed [Conventional Comments](https://conventionalcomments.org/) framework that you can follow to label your intent more specifically.

> *Unlabelled comments create ambiguity — is this a must-fix or a nice-to-have? Labels eliminate guesswork and prevent unnecessary round-trips.*

### PR011: Use neutral, non-accusatory language

Say "This function doesn't close the connection" instead of "You forgot to close the connection." Ask questions instead of giving commands: "What do you think about extracting this?" rather than "Extract this." Avoid "just," "simply," "obviously."

> *Written feedback lacks tone. Neutral language prevents misinterpretation and keeps reviews collaborative.*

### PR012: Approve when the PR improves code health, not when it's perfect
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an instruction so that it does give a recommendation whether it would or not approve the PR ? I think it's adding comments without siding


If the PR makes the codebase better and passes all checks, approve it. There is no such thing as perfect code, only better code. Don't block for polish.

> *Blocking on perfection creates frustration and slows delivery without proportional quality gains.*

### PR013: Use "Request Changes" without hesitation

If a PR has issues that must be addressed before merging, submit the review as **Request Changes** — not as a Comment with suggestions. This is not a personal judgement; it is a clear signal that the PR is not ready yet. Use it as many times as necessary until the PR actually looks good to merge. Approving out of politeness helps no one.

> *A "Comment" review with blocking feedback is ambiguous — the author may interpret it as optional. "Request Changes" removes all doubt and keeps the review loop honest. Candour is a kindness; silent approvals are not.*
Loading