Skip to content

chore: Add configuration files for Gemini PR reviews#7577

Open
matthewelwell wants to merge 1 commit into
mainfrom
chore/add-gemini-configuration
Open

chore: Add configuration files for Gemini PR reviews#7577
matthewelwell wants to merge 1 commit into
mainfrom
chore/add-gemini-configuration

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Adds configuration file for gemini code reviews as per schema here. Note that I have populated all fields, using default values where sufficient for our usage as I preferred to be explicit rather than implicit. Happy to remove default values if requested.

I also added the style guide, currently just pulled directly from the Notion page on our approach to PRs here.

How did you test this code?

N/a - will need testing with gemini code review after merge.

@matthewelwell matthewelwell requested a review from a team as a code owner May 22, 2026 10:40
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team May 22, 2026 10:40
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored May 22, 2026 10:40am
flagsmith-frontend-preview Ignored Ignored May 22, 2026 10:40am
flagsmith-frontend-staging Ignored Ignored May 22, 2026 10:40am

Request Review

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the chore label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7577 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7577 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7577 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7577 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7577 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  34.7 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  43 seconds
commit  927ccfc
info  🔄 Run: #16911 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Comment thread .gemini/config.yaml
Comment on lines +12 to +16
pull_request_opened:
help: false
summary: false
code_review: false
include_drafts: false
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaults here are as per the following suggestion (to show the diff, not to be committed)

Suggested change
pull_request_opened:
help: false
summary: false
code_review: false
include_drafts: false
pull_request_opened:
help: false
summary: false
code_review: true
include_drafts: true

I've chosen to turn off all automated PR reviews in favour of using the manual review option, at least to begin with.

Comment thread .gemini/config.yaml

code_review:
disable: false
comment_severity_threshold: HIGH
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the non-default, the default is MEDIUM.

@matthewelwell matthewelwell changed the title chore: Add .gemini/config.yaml and styleguide.md chore: Add configuration files for Gemini PR reviews May 22, 2026
Comment thread .gemini/styleguide.md

> *Written feedback lacks tone. Neutral language prevents misinterpretation and keeps reviews collaborative.*

### PR012: Approve when the PR improves code health, not when it's perfect
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an instruction so that it does give a recommendation whether it would or not approve the PR ? I think it's adding comments without siding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants