Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/libs/actions/IOU/PayMoneyRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -773,10 +773,15 @@ function completePaymentOnboarding(
onboardingPurpose = CONST.ONBOARDING_CHOICES.CHAT_SPLIT;
}
const {onboardingMessages} = getOnboardingMessages();
// choice can hold a backend value with no onboarding message (e.g. classicAdmin for Classic-invited admins), so skip instead of crashing on the undefined lookup below.
const onboardingMessage = onboardingMessages[onboardingPurpose];
if (!onboardingMessage) {
return;
}

completeOnboarding({
engagementChoice: onboardingPurpose,
onboardingMessage: onboardingMessages[onboardingPurpose],
onboardingMessage,
firstName: personalDetails?.firstName,
lastName: personalDetails?.lastName,
adminsChatReportID,
Expand Down
12 changes: 12 additions & 0 deletions tests/actions/IOUTest/PayMoneyRequestTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2018,5 +2018,17 @@ describe('actions/IOU/PayMoneyRequest', () => {
}),
);
});

it('does not call completeOnboarding when the choice has no onboarding message (e.g. classicAdmin for Classic-invited admins)', () => {
const introSelected: IntroSelected = {
// @ts-expect-error classicAdmin is a backend-only choice value with no App onboarding message, intentionally outside the OnboardingPurpose union
choice: 'classicAdmin',
inviteType: CONST.ONBOARDING_INVITE_TYPES.WORKSPACE,
isInviteOnboardingComplete: false,
};

expect(() => completePaymentOnboarding(CONST.PAYMENT_SELECTED.PBA, introSelected, false, [CONST.BETAS.ALL], CARLOS_ACCOUNT_ID)).not.toThrow();
expect(completeOnboardingSpy).not.toHaveBeenCalled();
});
});
});
Loading