-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] OpenReport: pass includePartiallySetupBankAccounts=true if Concierge report #78617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] OpenReport: pass includePartiallySetupBankAccounts=true if Concierge report #78617
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
If this isn't treated as regression (as PR was deployed 2 weeks ago), can I continue the review since I already investigated the issue? |
|
@s77rt this issue is still reproducible in another scenario. Steps to reproduce:
Screen.Recording.2025-12-31.at.4.06.32.am.mov |
| accountIDList: participantAccountIDList ? participantAccountIDList.join(',') : '', | ||
| parentReportActionID, | ||
| transactionID: transaction?.transactionID, | ||
| includePartiallySetupBankAccounts: isConciergeChatReport(allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change fixes the linked blocker issue (Concierge case) so feel free to merge.
Screen.Recording.2025-12-31.at.4.13.46.am.mov
Btw this is not a complete solution as stated here. (not blocker as happening on prod)
MarioExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, let's wait for @aimane-chnaif to finish the reviewer checklist.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-12-31.at.4.13.46.am.mov |
MarioExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @s77rt and @aimane-chnaif
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…BankAccounts [CP Staging] OpenReport: pass includePartiallySetupBankAccounts=true if Concierge report (cherry picked from commit 9cfc8b2) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.89-5 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.89-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.90-0 🚀
|
@srikarparsi
Explanation of Change
Passing
includePartiallySetupBankAccountsastrueif target report is Concierge. This is only done for Concierge to keep changes minimal as I think doing same for all reports would probably break some test scenarios from #71659 (didn't check).Fixed Issues
$ #78612
PROPOSAL:
Tests
Screen.Recording.2025-12-31.at.12.14.53.AM.mov
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari