Shadow mapping#19
Open
AwesomeDudeDK wants to merge 70 commits into
Open
Conversation
…e/okay-engine into shadow-mapping
…e/okay-engine into shadow-mapping
Evan-Bertis-Sample
left a comment
Evan-Bertis-Sample
left a comment
Owner
There was a problem hiding this comment.
Some minor changes! In the future, we should separate out the depth map rendering logic (perhaps a seperate pass/class of utilities), but for now this is fine.
| } | ||
| } | ||
|
|
||
| // display the depth map onto the screen |
There was a problem hiding this comment.
Could we remove this? In the future we should use an external tool like RenderDoc for debuging textures.
| return frustumCornersWorld(aspectRatio, getFar(aspectRatio)); | ||
| } | ||
|
|
||
| std::array<glm::vec3, 8> frustumCornersWorld(float aspectRatio, float shadowFar) { |
There was a problem hiding this comment.
I don't think Camera is an appropriate place to put this function. You should make another function within scene pass to perform this transformation.
Co-authored-by: Jalil Hemphill <jalilhemphill1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.