Skip to content

feat: variable group#478

Closed
tmichela wants to merge 2 commits intomasterfrom
feat/variable-group
Closed

feat: variable group#478
tmichela wants to merge 2 commits intomasterfrom
feat/variable-group

Conversation

@tmichela
Copy link
Copy Markdown
Member

@tmichela tmichela commented Jul 18, 2025

Adds the VariableGroup class to organize related variables into components.

https://damnit--478.org.readthedocs.build/en/478/configuration_and_management/#group

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 95.26066% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.37%. Comparing base (93a2b3d) to head (37f73cd).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
damnit/ctxsupport/damnit_ctx.py 95.91% 8 Missing ⚠️
damnit/backend/extract_data.py 66.66% 1 Missing ⚠️
damnit/ctxsupport/ctxrunner.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
+ Coverage   78.84%   79.37%   +0.52%     
==========================================
  Files          37       37              
  Lines        6562     6763     +201     
==========================================
+ Hits         5174     5368     +194     
- Misses       1388     1395       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmichela tmichela marked this pull request as ready for review August 1, 2025 16:12
@tmichela tmichela added the enhancement New feature or request label Aug 6, 2025
Comment thread damnit/ctxsupport/damnit_ctx.py Outdated
Comment thread damnit/ctxsupport/damnit_ctx.py Outdated
@tmichela
Copy link
Copy Markdown
Member Author

@takluyver I think the last change adresses what we discussed yesterday.

@tmichela
Copy link
Copy Markdown
Member Author

tmichela commented Sep 8, 2025

I'll merge in a couple days, if there's no new comments.

Comment thread docs/backend.md Outdated
Comment thread damnit/ctxsupport/damnit_ctx.py
Comment thread damnit/ctxsupport/damnit_ctx.py
Comment thread damnit/ctxsupport/damnit_ctx.py Outdated
Comment thread damnit/ctxsupport/damnit_ctx.py Outdated
Comment thread damnit/ctxsupport/damnit_ctx.py
@dataclass
class _GroupBase:
title: str | None = field(default=None, kw_only=True)
tags: tuple[str] | None = field(default=None, kw_only=True)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to make tags always a tuple, using () as the default instead of None?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went for the same default as Variable, for consistency.

@tmichela tmichela force-pushed the feat/variable-group branch from 711d6c5 to 4ea4ea2 Compare December 10, 2025 16:24
@tmichela
Copy link
Copy Markdown
Member Author

tmichela commented Feb 9, 2026

closing in favour of #532

@tmichela tmichela closed this Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants