Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 78.84% 79.37% +0.52%
==========================================
Files 37 37
Lines 6562 6763 +201
==========================================
+ Hits 5174 5368 +194
- Misses 1388 1395 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
takluyver
reviewed
Aug 8, 2025
takluyver
reviewed
Aug 8, 2025
Member
Author
|
@takluyver I think the last change adresses what we discussed yesterday. |
Member
Author
|
I'll merge in a couple days, if there's no new comments. |
JamesWrigley
requested changes
Sep 15, 2025
takluyver
reviewed
Sep 25, 2025
| @dataclass | ||
| class _GroupBase: | ||
| title: str | None = field(default=None, kw_only=True) | ||
| tags: tuple[str] | None = field(default=None, kw_only=True) |
Member
There was a problem hiding this comment.
Would it be simpler to make tags always a tuple, using () as the default instead of None?
Member
Author
There was a problem hiding this comment.
I went for the same default as Variable, for consistency.
a444a80 to
28341c4
Compare
3044dfe to
086b947
Compare
711d6c5 to
4ea4ea2
Compare
Member
Author
|
closing in favour of #532 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
VariableGroupclass to organize related variables into components.https://damnit--478.org.readthedocs.build/en/478/configuration_and_management/#group