FEAT(GUI): Hierarchical column header view#520
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 78.84% 79.20% +0.35%
==========================================
Files 37 37
Lines 6562 6829 +267
==========================================
+ Hits 5174 5409 +235
- Misses 1388 1420 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5788e35 to
bf5c321
Compare
|
The screenshot looks pretty nice. 👍 Do we want to impose some kind of sanity limit on the hierarchy depth? Or just trust people to be sensible with it? There's quite a bit of detailed Qt code here using APIs that I'm not familiar with. Do you want to do a pair review in the new year? Or I'm happy to trust you on it, but maybe if we do that we should make an off switch to quickly go back to simple table headings in case of bugs (and then make a note to get rid of it in a few more months). |
I would trust people will be sensible 🙃 I don't really think it will ever go over 2 levels to be honnest.
Not sure this is actually that useful, TBH. It's not impossible there's a bug in the sizes calculation, but I wouldn't be able to spot that by reading the code 🙃
Good point, I just pushed that option. |
|
Apologies, I completely missed this 😳 Will take it for a spin today. |
JamesWrigley
left a comment
There was a problem hiding this comment.
Very shallow review. I tested it manually and it seems to work very nicely ✨
JamesWrigley
left a comment
There was a problem hiding this comment.
LGTM!
(but pls squash merge or rebase 🙏 )
note: to be removed after some time of use, once it's battle tested. fix: remove development remnant
1d39b97 to
4bd133d
Compare
|
Thanks for the reviews! |
Adds hierarchical columns header view, to improve visually grouping Variables that belong together.
Hierarchy is built from variable's title: each '/' character splits the title to the next level.
Will be more important once #478 is merged.