security(webview): restrict native JS channel callbacks to configured origin#2285
Draft
cursor[bot] wants to merge 1 commit into
Draft
security(webview): restrict native JS channel callbacks to configured origin#2285cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
… origin Native InAppWebView JavaScript channel handlers accepted postMessage callbacks from any document loaded in the WebView, including malicious iframes or redirect targets. Mirror the existing web iframe origin check by validating the current page origin against the configured WebView URL before executing YAML actions. Adds unit tests for origin derivation and validation helpers. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability summary
Native
InAppWebViewJavaScript channel handlers executed YAML actions for messages from any document loaded in the WebView, without validating the sender origin.Affected location
modules/ensemble/lib/widget/webview/native/webviewstate.dartmodules/ensemble/lib/widget/webview/webview_javascript_bridge_security.dartSecurity impact
Medium — A malicious iframe or redirect inside the WebView can invoke configured
javascriptChannelsand trigger privileged Ensemble actions.Attack path
callHandler(channel, data)payloadsaddJavaScriptHandlercallback (no origin check)onMessageReceivedYAML actions run with attacker dataFix
Validate
controller.getUrl()?.originagainst the origin derived from the configured WebView URL before executing actions. Fail closed on mismatch.Tests
modules/ensemble/test/webview_javascript_bridge_security_test.dart