fix(webview): render inline HTML on web instead of permanent Loading state#2293
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(webview): render inline HTML on web instead of permanent Loading state#2293cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…state PR #2291 added html/htmlBaseUrl/injectedJavaScript support to the native InAppWebView path but left the web iframe implementation unchanged. On web, setting html clears url, so buildWidget always showed Loading... Load inline HTML via iframe srcdoc with the same base URL and injected script behavior as native initialData, and add unit tests for the shared document/origin helpers. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Trigger: A screen uses
EnsembleWebViewwith the newhtmlproperty (merged in PR #2291) on web.Impact: The widget shows
Loading...forever and never renders the HTML. Native/mobile works because onlynative/webviewstate.dartwas updated; the web iframe path still requiredurland treatedurl == nullas unloaded.Root cause
PR #2291 added
html,htmlBaseUrl, andinjectedJavaScriptto the controller and nativeInAppWebView(initialData), but the web implementation (web/webviewstate.dart) was not updated. Settinghtmlclearsurl, sobuildWidgetalways hit theLoading...branch.Fix
srcdoc, using shared helpers for base URL + optional injected script (matching native defaults).html/htmlBaseUrl/injectedJavaScriptchange.Validation
modules/ensemble/test/webview_html_content_test.dart.modules/ensemble:flutter test test/webview_html_content_test.dartDuplicate check
htmlsupport but only for native — this completes the web path for the same feature.executeActionawait — unrelated.