Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/js_widget/lib/src/mobile/js_widget.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/material.dart';
import 'package:js_widget/src/mobile/webview_debug_policy.dart';
// Import for Android features.
import 'package:webview_flutter_android/webview_flutter_android.dart';
// Import for iOS features.
Expand Down Expand Up @@ -91,7 +92,9 @@ class JsWidgetState extends State<JsWidget> {
)
..loadHtmlString(getHtmlContent());
if (controller.platform is AndroidWebViewController) {
AndroidWebViewController.enableDebugging(true);
if (androidWebViewDebuggingEnabled()) {
AndroidWebViewController.enableDebugging(true);
}
(controller.platform as AndroidWebViewController)
.setMediaPlaybackRequiresUserGesture(false);
}
Expand Down
12 changes: 12 additions & 0 deletions modules/js_widget/lib/src/mobile/webview_debug_policy.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import 'package:flutter/foundation.dart';

/// Whether Android WebView remote debugging may be enabled for this build.
///
/// Release/profile builds must return false so production WebViews cannot be
/// inspected or scripted via chrome://inspect (CWE-489).
bool androidWebViewDebuggingEnabled() =>
androidWebViewDebuggingEnabledForBuild(isDebugBuild: kDebugMode);

/// Build-mode gate used by [androidWebViewDebuggingEnabled] and unit tests.
bool androidWebViewDebuggingEnabledForBuild({required bool isDebugBuild}) =>
isDebugBuild;
16 changes: 16 additions & 0 deletions modules/js_widget/test/webview_debug_policy_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:js_widget/src/mobile/webview_debug_policy.dart';

void main() {
group('androidWebViewDebuggingEnabledForBuild', () {
test('disables debugging for release/profile builds', () {
expect(androidWebViewDebuggingEnabledForBuild(isDebugBuild: false),
isFalse);
});

test('allows debugging only for debug builds', () {
expect(
androidWebViewDebuggingEnabledForBuild(isDebugBuild: true), isTrue);
});
});
}
Loading