fix(js_widget): disable Android WebView debugging in release builds#2276
Open
cursor[bot] wants to merge 1 commit into
Open
fix(js_widget): disable Android WebView debugging in release builds#2276cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
AndroidWebViewController.enableDebugging(true) was called unconditionally, allowing chrome://inspect to attach to every JsWidget WebView in production. Gate debugging behind kDebugMode and add regression tests. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability summary
Medium (CWE-489): Android WebView remote debugging enabled unconditionally in production
JsWidgetcalledAndroidWebViewController.enableDebugging(true)for every Android WebView instance, including release builds.Affected location
modules/js_widget/lib/src/mobile/js_widget.dartSecurity impact
When WebView debugging is enabled, anyone with USB/ADB access (or a machine that can use
chrome://inspectagainst a connected device) can attach to embeddedJsWidgetWebViews, inspect DOM content, execute JavaScript in the WebView context, and intercept or modify in-WebView behavior. This exposes sensitive data rendered in JS widgets (charts, third-party embeds, etc.) outside the intended app trust boundary.Attack path
JsWidgeton Android.JsWidgetState.instantiateController()always enabled debugging before this change.Fix approach
AndroidWebViewController.enableDebuggingbehindkDebugModeviaandroidWebViewDebuggingEnabled().webview_debug_policy.dartand unit tests asserting debugging is disabled for non-debug builds.Tests
modules/js_widget/test/webview_debug_policy_test.dart